Existence validator #435
Merged
Existence validator #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korpling changes 04/17/15
…s a number of changes in front and back ends. In the front end, I modified the QueryController class to perform validateQuery( ) with one more argument, the corpusName, which will be passed to back end at the time of validation (and obviously necessary for the new existence validator). Before, this argument was not passed from the front end and the corpusList in QueryServiceImpl was a empty linkedList (since previously no functionality in the validation needs the corpus name). In the backend, I mainly added AnnotationExistenceValidator class. This is configured within the Java Spring framework, with the added entry in AnnisParser-Context.xml (including reference to annisDao). The new class simply get the available node annotations in the corpus (if selected), and checks if the nodes in the input query matches one of these valid annotation names. One problem as of now is that, if no corpus is selected at the time that the validation happens, then the Node existence validation will not be performed. To change that situation we need to think of whether we want all validations to happen only when a corpus is selected by the user.
… corpus selection problem (validation happens when corpos selection changes now), and the corpora accumulation bugs in repeated validation processes with different corpus selections.
…is commit I finally add the functionality of the validation when multiple corpora are selected.In that scenario, the annotation name is deemed valid as long as it exists in one of the selected corpora.
|
I used this opportunity to clean up some of the existing internal AQL error handling and now semantic errors are also shown in the AQL editor with the locations where the error actually occurred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several commits on the works of an annotation existence validator (issue Annotation name validation #190). The validator is incorporated along with the AQL checks in the backend and it is being run whenever a change in the query window or in the corpus selection changes. The validator also supports the case of multiple corpora selection (it is valid as long as the annotation exists in one of the selected corpora).