Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension host terminated unexpectedly. #135

Open
RustyWraith opened this issue Mar 23, 2021 · 14 comments
Open

Extension host terminated unexpectedly. #135

RustyWraith opened this issue Mar 23, 2021 · 14 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@RustyWraith
Copy link

Enabling the extension causes the "Extension host terminated unexpectedly" error.
image

Versions
Version: 1.55.0-insider
Commit: a6f6b4aa8e3a688d9a5cbcd5df14af511ce2bd8e
Date: 2021-03-23T05:28:25.637Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT ia32 10.0.18363

@kortina
Copy link
Owner

kortina commented Mar 23, 2021

Hmm, I am running with no errors on Insiders:

Version: 1.55.0-insider
Commit: 469e4f6e2755b220dae3eccb04d1ddc587b84a5a
Date: 2021-03-22T05:14:29.671Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Darwin x64 20.3.0

Are you able to get any more detailed logs?

@kortina
Copy link
Owner

kortina commented Mar 23, 2021

Anyone else having this issue?

@kortina kortina added bug Something isn't working help wanted Extra attention is needed labels Mar 23, 2021
@RustyWraith
Copy link
Author

RustyWraith commented Mar 23, 2021

image
image
log.log

@kortina
Copy link
Owner

kortina commented Mar 23, 2021

From a quick look, it appears maybe you do not have git installed and this is a dependency? Can you confirm?

  1. quickfix: install git
  2. mid term: we can try to have a fallback, but this may really impact performance, so you prolly want to do (1) anyway

Surprised this has never come up before if this is the root cause...

Confirmed git is a dep: https://github.com/kortina/vscode-markdown-notes/blob/master/src/findNonIgnoredFiles.ts#L26

@RustyWraith
Copy link
Author

RustyWraith commented Mar 23, 2021

I've installed git system-wide and added path to git_path:
image
The error changed:

findNonIgnoredFiles-git-exec-error Error: Command failed: git check-ignore
fatal: not a git repository (or any of the parent directories): .git

The Extension crushes only if specific folder is being opened:

D:\backup\Gdrive\LOGBOOK\Обработка_результатов

Could it be almighty Russian "I'll slip into you path and break everything" Cyrillic?

UPD:
Still a crash after a directory renamed.

@kortina
Copy link
Owner

kortina commented Mar 23, 2021

Maybe. Do you still get a crash if you checkout the source for this repo and open the test dir: https://github.com/kortina/vscode-markdown-notes/tree/master/test

@RustyWraith
Copy link
Author

Works fine.
image
Some folders cause crashes:
image
I have no idea, what crashing folders have in common.

@kortina
Copy link
Owner

kortina commented Mar 23, 2021

Maybe find 1 crashing folder, and then go through and remove all files except 1 for each file and see if you can isolate the crash to a specific file causing it?

@RustyWraith
Copy link
Author

It's somehow connected with total size of .txt files.
If any (I didn't test all of them, only tested a few) .txt of size 20+MB is deleted, the error is gone.
image

@krry
Copy link

krry commented Jun 13, 2021

First of all, thanks for this great extension! It makes note-keeping in VSCode with Foam much more slick and fun.

I'm experiencing similar behavior, in that Markdown Notes seems to be crashing the extension host, but a different error message in the VSCode console.

Screen Shot 2021-06-12 at 23 07 18

I don't understand why it fails to find /bin/sh which is assuredly present.

When I disable Markdown Notes and reload the VSCode window, the extension host no longer crashes.

I'm installing Insiders now to test there as well.

@jeffmcneill
Copy link

Similar issue:
Screenshot from 2022-09-21 17-42-01

crashing the extensions and VS code itself.

@kortina
Copy link
Owner

kortina commented Sep 21, 2022

I'm unable to replicate this issue.

@jeffmcneill what OS are you on? How many files and folders are in the project folder you're trying to use the extension with? (Maybe a project size issue similar to @RustyWraith's?)

@jeffmcneill
Copy link

@kortina

  • Debian Testing
  • VS Code 1.71.2
  • Project folder has a large number of files and folders, as I use this as a general text editor. Hundreds of folders, thousands of files. Does the extension try and read those files/folders in some way?

@kortina
Copy link
Owner

kortina commented Sep 21, 2022

Yes, it parses the contents of every file to find backlinks and tags. It probably won't work for such a large project folder. Long term it probably makes more sense to move all of this to a language server / background process, but that's not the way it works today. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants