-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension host terminated unexpectedly. #135
Comments
Hmm, I am running with no errors on Insiders:
Are you able to get any more detailed logs? |
Anyone else having this issue? |
From a quick look, it appears maybe you do not have
Surprised this has never come up before if this is the root cause... Confirmed git is a dep: https://github.com/kortina/vscode-markdown-notes/blob/master/src/findNonIgnoredFiles.ts#L26 |
Maybe. Do you still get a crash if you checkout the source for this repo and open the test dir: https://github.com/kortina/vscode-markdown-notes/tree/master/test |
Maybe find 1 crashing folder, and then go through and remove all files except 1 for each file and see if you can isolate the crash to a specific file causing it? |
First of all, thanks for this great extension! It makes note-keeping in VSCode with Foam much more slick and fun. I'm experiencing similar behavior, in that Markdown Notes seems to be crashing the extension host, but a different error message in the VSCode console. I don't understand why it fails to find When I disable Markdown Notes and reload the VSCode window, the extension host no longer crashes. I'm installing Insiders now to test there as well. |
I'm unable to replicate this issue. @jeffmcneill what OS are you on? How many files and folders are in the project folder you're trying to use the extension with? (Maybe a project size issue similar to @RustyWraith's?) |
|
Yes, it parses the contents of every file to find backlinks and tags. It probably won't work for such a large project folder. Long term it probably makes more sense to move all of this to a language server / background process, but that's not the way it works today. Sorry! |
Enabling the extension causes the "Extension host terminated unexpectedly" error.
![image](https://user-images.githubusercontent.com/11280514/112157565-63f3bb80-8bf8-11eb-8d0a-f9cc94266863.png)
Versions
Version: 1.55.0-insider
Commit: a6f6b4aa8e3a688d9a5cbcd5df14af511ce2bd8e
Date: 2021-03-23T05:28:25.637Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT ia32 10.0.18363
The text was updated successfully, but these errors were encountered: