Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance documentation? #3

Closed
tin6150 opened this issue Dec 26, 2018 · 1 comment
Closed

enhance documentation? #3

tin6150 opened this issue Dec 26, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@tin6150
Copy link

tin6150 commented Dec 26, 2018

Howdy bravecow,
Thanks for this repo. The examples are pretty good and concisely shows what each control add which feature, but could you elaborate more on how one can use them in an existing html page containing a single map using mapbox gl js ?

For instance, I have tried to use hopefully the simpler "style" feature, tried to trim your example to just have that as an example, but have not been able to do so. It would be nice if things are not wrapped by webpack. Even after installing webpack and figuring out to edit docs.js, I was still got
exampleLocalization is not defined.

A single example page with plain html/js code for a single feature, listing all required tools/components, would be really helpful.

Much thanks!

@korywka
Copy link
Owner

korywka commented Jan 22, 2019

👋Thanks for feedback. Docs moved to stackblitz.io.

<script src="./styles.js"></script>

Should export StylesControl to window too.

@korywka korywka closed this as completed Jan 23, 2019
@korywka korywka added the enhancement New feature or request label Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants