Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default AstronomicalCalculator #137

Closed
msalle opened this issue Mar 5, 2019 · 4 comments
Closed

default AstronomicalCalculator #137

msalle opened this issue Mar 5, 2019 · 4 comments
Labels
question

Comments

@msalle
Copy link

msalle commented Mar 5, 2019

I was wondering why the SunTimesCalculator() is the default calculator in AstronomicalCalculator.java lines 83-85 instead of the more precise NOAACalculator() ? The latter, for example, makes a difference between years, while the former just returns the same zmanim every year (counting the days from 1 January).
@KosherJava
Copy link
Owner

@msalle ,
There is no good reason to have the USNO algorithm as the default, and I actually changed the default in https://kosherjava.com/zmanim-project/zmanim-calendar-generator/ . In the past, people knew of the USNO charts and were more comfortable with that one. I will hopefully change the default in the near future.

@msalle
Copy link
Author

msalle commented Mar 6, 2019

That makes sense, thanks.
Mischa

@BehindTheMath
Copy link
Contributor

@KosherJava Can this be closed? I believe this was resolved by b69dc31.

@KosherJava
Copy link
Owner

Closing this as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msalle @KosherJava @BehindTheMath