Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate from tty2web to another url in the browser #49

Closed
fc92 opened this issue Mar 8, 2023 · 2 comments
Closed

Navigate from tty2web to another url in the browser #49

fc92 opened this issue Mar 8, 2023 · 2 comments

Comments

@fc92
Copy link

fc92 commented Mar 8, 2023

When file a bug report (see below for feature requests)

Please answer these quesions for a bug report. Thanks!

What version of tty2web are you using (tty2web --version)?

tty2web version 2.7.0+1917209

What operating system and browser are you using?

Linux AMD64, Firefox & Chrome
image

What did you do?

If possible, please provide the command you ran.
I need url links or ability to redirect from current tty2web app to another url in the browser. I tried adding xterm.js addon but without success:
https://github.com/fc92/tty2web/blob/WebLinksAddon/js/src/xterm.ts

The terminal UI is built in https://github.com/fc92/poker/blob/groom/internal/groom/welcome.go
The url display is line 90:
displayUrl.SetText(roomUrl)

What did you expect to see?

http and https url like github url should be displayed as link in the browser and the user can click on the link to open the url

What did you see instead?

Url is display as regular text. I cannot even do a copy / paste.
If possible, please provide the output of the command and your browser's console output.

When file a new feature proposal

Please provide an actual usecase that requires your new feature.
I need url links or ability to redirect from current tty2web app to another url in the browser.
Capture d’écran du 2023-03-08 01-10-17

@kost
Copy link
Owner

kost commented Mar 8, 2023

Hello!
Can you try the following release: https://github.com/kost/tty2web/releases/tag/v2.7.1
Just added weblinks support.
Hope it helps!

@kost kost closed this as completed Mar 8, 2023
@fc92
Copy link
Author

fc92 commented Mar 8, 2023

It's working, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants