Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs sometimes inaccurately classified as non-flaky due to duplicate failure notifications #84

Open
kostmo opened this issue Apr 28, 2020 · 0 comments

Comments

@kostmo
Copy link
Owner

kostmo commented Apr 28, 2020

Part of the logic for determining non-flakiness checks whether a job has failed more than once at the same commit (i.e., if it fails consistently). However, sometimes CircleCI sends multiple failure notifications for the same Build ID. We should deduplicate these; only count multiple failures if they came from distinct Build IDs at a given commit and job.

One attempt has been made so far to fix this, by introducing a de-duplicating database view (see 70269e9). However, the query performed poorly, probably because of the way data was split across multiple tables.

The next step is to consolidate the data into one table so that a unified index can be created, then measure the performance of the query again.

cc @malfet @orionr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant