Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cann't run gammaCKpar on a simple comparion instance #18

Closed
LUSAQX opened this issue Nov 19, 2017 · 3 comments
Closed

cann't run gammaCKpar on a simple comparion instance #18

LUSAQX opened this issue Nov 19, 2017 · 3 comments

Comments

@LUSAQX
Copy link

LUSAQX commented Nov 19, 2017

Hi,

Please check the code as follows which returned

Error in { : task 1 failed - "subscript out of bounds"

dfA=list(c('A2 Infant','Express Logistics'))
names(dfA) = c('name')
dfB=list(c('A2 Infant','Cargo Solutions'))
names(dfB) = c('name')
g_firstname <- gammaCKpar(dfA$name, dfB$name)

But when shifting to function gammaCK2par

it could work.

Could you please advise how to fix the code to recall function gammaCKpar well on the instance above?

Cheers

@LUSAQX
Copy link
Author

LUSAQX commented Nov 19, 2017

I have got the solution, i.e. customize the cut.a and cut.p value to replace the default.

@tedenamorado
Copy link
Collaborator

Thanks a lot for raising this point!

You are completely right. If there a not observations between the first and second cutoffs, then the function should fail. We will add a more informative error message when this happens.

@tedenamorado
Copy link
Collaborator

Hi, I just wanted to let you know that thanks to the error you brought our attention, we have improved gammaCKpar. If I am not wrong you are using a Windows machine, that is why you got an error message related to the parallelization of the function. More important than the parallelization problem is the fact that we did not have a proper warning message telling users that sometimes a partial match does not work given the default settings. Thanks to you, we have pushed an updated version of gammaCKpar that includes such a warning.

Please, if you find any further issues when using fastLink, just say the word!

Thanks a lot for your great feedback and Happy holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants