Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for new cross-stack reference #38

Open
3 tasks done
Kotaimen opened this issue Sep 22, 2018 · 3 comments
Open
3 tasks done

Refactor for new cross-stack reference #38

Kotaimen opened this issue Sep 22, 2018 · 3 comments

Comments

@Kotaimen
Copy link
Owner

Kotaimen commented Sep 22, 2018

  • Process of convert config to boto3 call
  • Abstract stack Command objects
  • Separate boto3 call from click call
@Kotaimen Kotaimen created this issue from a note in awscfncli 2.1 (To do) Sep 22, 2018
@Kotaimen Kotaimen moved this from To do to In progress in awscfncli 2.1 Sep 22, 2018
@Kotaimen Kotaimen moved this from In progress to Done in awscfncli 2.1 Sep 25, 2018
@Kotaimen
Copy link
Owner Author

Hi @GlieseRay,

Does that make sense to you to change output reference syntax from:

${Stage.Stack.OutputName}

To:

${Stage.Stack.Outputs.OutputName}

So we can add other stack references other than outputs in the future?
This syntax is also identical with what nested stack uses:

Stack.Outputs.OutputName

@Kotaimen Kotaimen reopened this Oct 24, 2018
awscfncli 2.1 automation moved this from Done to In progress Oct 24, 2018
@Kotaimen Kotaimen closed this as completed Dec 1, 2018
awscfncli 2.1 automation moved this from In progress to Done Dec 1, 2018
@Kotaimen Kotaimen added this to TODO in awscfncli 2.2 via automation Jan 19, 2019
@Kotaimen
Copy link
Owner Author

Hi @GlieseRay:

  1. I'd still like to support following use case:

    ${Stage.Stack.Config.ConfigName}
    ${Stage.Stack.Parameters.ParameterName}
    ${Stage.Stack.Outputs.OutputName}
    

    This leaves us room for future expansion. of course with 2.1 released we need to keep support for old format:

    ${Stage.Stack.OutputName}
    
  2. I think current "string template replacement" way of implement stack reference is not ideal and I would like to see it refactored.

  3. When retrieving outputs from a referenced stack data is not cached, I'm wondering that could be improved?

@Kotaimen Kotaimen reopened this Jan 19, 2019
awscfncli 2.1 automation moved this from Done to In progress Jan 19, 2019
@Kotaimen Kotaimen moved this from TODO to In Progress in awscfncli 2.2 Feb 24, 2019
awscfncli 2.2 automation moved this from In Progress to Done Feb 24, 2019
@GlieseRay
Copy link
Collaborator

@Kotaimen
I am going to use mustache or something else. Testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
awscfncli 2.1
  
In progress
awscfncli 2.2
  
Done
Development

No branches or pull requests

2 participants