Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): start if no write permmision for logdir #178

Merged
merged 4 commits into from Feb 1, 2021
Merged

Conversation

kotakanbe
Copy link
Collaborator

@kotakanbe kotakanbe commented Feb 1, 2021

What did you implement:

./go-cve-dictionary server
EROR[02-02|06:17:49] Failed to create a log file              err="open /var/log/vuls/cve-dictionary.log: permission denied"
INFO[02-02|06:17:50] Starting HTTP Server...
EROR[02-02|06:17:50] open /var/log/vuls/access.log: permission denied

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

./go-cve-dictionary server
EROR[02-02|07:13:47] Failed to create a log file              err="open /var/log/vuls/cve-dictionary.log: permission denied"
INFO[02-02|07:13:47] Starting HTTP Server...
EROR[02-02|07:13:47] Failed to create a log file: open /var/log/vuls/access.log: permission denied
INFO[02-02|07:13:47] Listening on 127.0.0.1:1323

   ____    __
  / __/___/ /  ___
 / _// __/ _ \/ _ \
/___/\__/_//_/\___/ v3.3.10-dev
High performance, minimalist Go web framework
https://echo.labstack.com
____________________________________O/_______
                                    O\
⇨ http server started on 127.0.0.1:1323

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kotakanbe kotakanbe changed the title Log fix(server): start if no write permmision for logdir Feb 1, 2021
@kotakanbe kotakanbe merged commit a2bfda9 into master Feb 1, 2021
@kotakanbe kotakanbe deleted the log branch July 14, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant