Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionMode.Error doesn't work on FeatureSpec #1864

Closed
aids61517 opened this issue Nov 25, 2020 · 2 comments · Fixed by #1873
Closed

AssertionMode.Error doesn't work on FeatureSpec #1864

aids61517 opened this issue Nov 25, 2020 · 2 comments · Fixed by #1873
Assignees
Labels
bug 🐛 Issues that report a problem or error in the code. framework 🏗️ Pertains to the core structure and components of the Kotest framework.
Milestone

Comments

@aids61517
Copy link

aids61517 commented Nov 25, 2020

version: io.kotest:kotest-runner-junit5:4.3.1
kotlin version: 1.4.10
Android Studio version: 4.1.1

assertion mode doesn't work on FeatureSpec, and Tests passed always equal to 0 even if I do assertion

class FeatureSpecTest : FeatureSpec({
  assertions = Error

  feature("Test feature") {
    scenario("test scenario") {
    }
  }
})

image

In do assertion case:

class FeatureSpecTest : FeatureSpec({
  assertions = Error

  feature("Test feature") {
    scenario("test scenario") {
      val a = 1
      a shouldBe 1
    }
  }
})

Tests passed still equal to 0
image

@LeoColman LeoColman added bug 🐛 Issues that report a problem or error in the code. framework 🏗️ Pertains to the core structure and components of the Kotest framework. labels Nov 27, 2020
@ashishkujoy ashishkujoy self-assigned this Nov 28, 2020
@ashishkujoy
Copy link
Contributor

Fixed in master

@sksamuel sksamuel mentioned this issue Dec 1, 2020
43 tasks
@sksamuel sksamuel added this to the 4.3.2 milestone Dec 7, 2020
@sksamuel
Copy link
Member

4.3.2 is released with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issues that report a problem or error in the code. framework 🏗️ Pertains to the core structure and components of the Kotest framework.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants