Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jackson and js native with kotlinx-serialization json parsing in kotest-assertions #2004

Closed
jschneidereit opened this issue Jan 20, 2021 · 3 comments
Closed

Replace jackson and js native with kotlinx-serialization json parsing in kotest-assertions #2004

jschneidereit opened this issue Jan 20, 2021 · 3 comments
Assignees
@jschneidereit
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Milestone
4.4

Comments

@jschneidereit
Copy link
Member

The kotlinx-serialization library can do arbitrary json parsing and is a cross platform project by default. Replacing Jackson with kotlinx-serialization would make kotest-assertions a cross platform module by default.
@jschneidereit jschneidereit added the enhancement ✨ Suggestions for adding new features or improving existing ones. label Jan 20, 2021
@sksamuel sksamuel changed the title Replace jackson with kotlinx-serialization json parsing in kotest-assertions Replace jackson and js native with kotlinx-serialization json parsing in kotest-assertions Jan 20, 2021
@jschneidereit
Copy link
Member Author

Might be blocked by Kotlin/kotlinx.serialization#204 unless we're ok with temporarily reading resources right into memory this.javaClass.getResourceAsStream(resource) see io.kotest.assertions.json.resources.kt

@sksamuel
Copy link
Member

I don't think a test needs to be streaming. Loading into memory seems fine ?

@jschneidereit jschneidereit mentioned this issue Jan 20, 2021
Merged
@sksamuel sksamuel added this to the 4.4 milestone Jan 24, 2021
@sksamuel sksamuel mentioned this issue Jan 24, 2021
Closed
43 tasks
@jschneidereit
Copy link
Member Author

Fixed in #2006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jschneidereit jschneidereit

Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
2 participants
@sksamuel @jschneidereit