Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test config is not recognized on tests run within a context #2050

Closed
ghost opened this issue Feb 5, 2021 · 4 comments · Fixed by #2258
Closed

test config is not recognized on tests run within a context #2050

ghost opened this issue Feb 5, 2021 · 4 comments · Fixed by #2258
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones. framework 🏗️ Pertains to the core structure and components of the Kotest framework. pinned 📌 Issues of high importance or that need to remain visible.
Milestone
4.6

Comments

@ghost
Copy link

ghost commented Feb 5, 2021

In the code here https://gist.github.com/slathropSR/f9c420c666b1cb3c0279e6f2afc38a1e the test running in the context will not execute unless the line with a default config is un commented.

It looks like the test config on a test defined within a context is not being honored.
@sksamuel
Copy link
Member

sksamuel commented Feb 6, 2021

Ok I see the problem. The context block does not have tags, so will not be picked up as you say.
The solution is to allow config at all levels, which is planned for 4.5

@sksamuel
Copy link
Member

sksamuel commented Feb 6, 2021

#1370

@sksamuel sksamuel added this to the 4.5 milestone Feb 6, 2021
@sksamuel sksamuel added enhancement ✨ Suggestions for adding new features or improving existing ones. framework 🏗️ Pertains to the core structure and components of the Kotest framework. labels Feb 6, 2021
@sksamuel
Copy link
Member

sksamuel commented Feb 6, 2021

Workaround for now is spec level tags (the line you commented).

This was referenced Feb 6, 2021
Closed
Closed
@stale
Copy link

stale bot commented Apr 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 7, 2021
@stale stale bot closed this as completed Apr 15, 2021
@sksamuel sksamuel added pinned 📌 Issues of high importance or that need to remain visible. and removed wontfix labels Apr 15, 2021
@sksamuel sksamuel reopened this Apr 21, 2021
@sksamuel sksamuel modified the milestones: 4.5, 4.6 Apr 21, 2021
@sksamuel sksamuel mentioned this issue Apr 24, 2021
Closed
7 tasks
@sksamuel sksamuel modified the milestones: 4.6, 4.7 May 18, 2021
@sksamuel sksamuel mentioned this issue May 18, 2021
Closed
71 tasks
@sksamuel sksamuel modified the milestones: 4.7, 4.6 May 18, 2021
@sksamuel sksamuel mentioned this issue May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones. framework 🏗️ Pertains to the core structure and components of the Kotest framework. pinned 📌 Issues of high importance or that need to remain visible.
Projects
None yet
Milestone
4.6
Development

Successfully merging a pull request may close this issue.

Add container level config for should, describe, fun specs #2065 #2155 kotest/kotest
1 participant
@sksamuel