Optimize sorted matcher #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of sorting the list and comparing every value, we can interate through the list once and stop when we find an element that's larger than the follow element. This also allow us to add the out-of-order element and its index to the error message.
|
The build failure is the same as the master branch: the |
|
Yep, fixing the master build now as part of that issue. |
|
This is a great pr, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sorting the list and comparing every value, we can iterate
through the list once and stop when we find an element that's larger
than the following element. This also allows us to add the out-of-order
element and its index to the error message.
A similar optimization was added to the
containsInOrdermatcher, with the additional benefit that it will now work on unsorted collections.