-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Klib validation failing on CI but not locally #199
Comments
@JakeWharton thanks for reporting! |
There's nothing specific about JS target in this particular case, it just appears to be the first target to load a dump for merging. |
That module contains only generated sources, which are correctly picked up by the dump: https://github.com/cashapp/redwood/pull/1884/files#diff-01c56a8c31dca2ba8b0d2218624f995999da354e5ac75bc91877b5dbb6abd60c The sources are produced by adding a |
I tried adding the task to the source set as soon as possible (when the multiplatform plugin is applied), but it didn't change the outcome. |
I get a similar exception on Windows for this project when klib validation is enabled here (by adding
The relevant parts of the project layout look like this:
It seems like BCV tries to find the The workaround I found is putting this into apiValidation {
ignoredProjects += "live-tests"
} |
Attempt 1
Attempt 2
Attempt 3
I have not been able to reproduce this locally on my Mac. I tried executing the same command (after a
clean
) with--max-workers=3
to match the core count of the CI machine but it always succeeds (5 attempts).I also don't know why it's always this specific module and the JS target that fails. I apply it to ~40 modules in this build, most of which are multiplatform containing JS targets. Very weird.
It's possible the problem can be identified just from looking at the code of the plugin, but I don't have time to do that right now. I can try investigating more later tonight or tomorrow, but figured I'd file the issue first.
The text was updated successfully, but these errors were encountered: