Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterable<Double?>.toDataFrame() and Iterable<Float?>.toDataFrame() results in empty dataframe #630

Closed
Jolanrensen opened this issue Mar 19, 2024 · 0 comments · Fixed by #631
Closed

Iterable<Double?>.toDataFrame() and Iterable<Float?>.toDataFrame() results in empty dataframe #630

Jolanrensen opened this issue Mar 19, 2024 · 0 comments · Fixed by #631
Assignees
@Jolanrensen
Labels
bug Something isn't working invalid This doesn't seem right
Milestone
0.14.0

Comments

@Jolanrensen
Copy link
Collaborator

As the title says

listOf(1.0, 2.0).toDataFrame() gives an empty dataframe.

The overloads for Float? and Double? are missing here:
https://github.com/Kotlin/dataframe/blob/master/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/toDataFrame.kt

This is a critical miss.
@Jolanrensen Jolanrensen added bug Something isn't working invalid This doesn't seem right labels Mar 19, 2024
@Jolanrensen Jolanrensen added this to the 0.14.0 milestone Mar 19, 2024
@Jolanrensen Jolanrensen mentioned this issue Mar 19, 2024
Merged
@Jolanrensen Jolanrensen self-assigned this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolanrensen Jolanrensen

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

added toDataFrame for float- and double iterables Kotlin/dataframe
1 participant
@Jolanrensen