Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkipTestException #522

Closed
sksamuel opened this issue Jan 6, 2019 · 8 comments · Fixed by #805
Closed

SkipTestException #522

sksamuel opened this issue Jan 6, 2019 · 8 comments · Fixed by #805
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Milestone

Comments

@sksamuel
Copy link
Member

sksamuel commented Jan 6, 2019

Should we support skipling a test by thowing this exception like junit.

@LeoColman
Copy link
Member

Something like @Expected?

@sksamuel
Copy link
Member Author

sksamuel commented Jan 6, 2019

I don't know what @expected is.
I just mean inside a test you can throw SkipTestException and instead of failing, it acts like the test is ignored.

@sksamuel sksamuel added enhancement ✨ Suggestions for adding new features or improving existing ones. potential labels Jan 7, 2019
@LeoColman
Copy link
Member

Ah, I see...
I've never seen a test with this, but I don't think it will be hard to implement

@sksamuel sksamuel added this to the 3.4 milestone Feb 5, 2019
@sksamuel sksamuel removed the potential label Feb 5, 2019
@LeoColman
Copy link
Member

Reviving this issue:

Do we actually need this? Would this be useful to any of our users? I don't see this as being really necessary, as it's not very different from a return inside a test, is it?

Tell me if we need this, or if we can close this issue for now.

@sksamuel
Copy link
Member Author

sksamuel commented Jun 3, 2019 via email

@sksamuel
Copy link
Member Author

sksamuel commented Jun 3, 2019 via email

@LeoColman
Copy link
Member

I mean, it's very easy to implement, I just want to see if we want it. Perhaps it's so easy to implement that we can just do it xD

@sksamuel
Copy link
Member Author

sksamuel commented Jun 4, 2019 via email

LeoColman added a commit that referenced this issue Jun 4, 2019
LeoColman added a commit that referenced this issue Jun 4, 2019
LeoColman added a commit that referenced this issue Jun 6, 2019
LeoColman added a commit that referenced this issue Jun 6, 2019
@sksamuel sksamuel mentioned this issue Jul 13, 2019
39 tasks
sksamuel pushed a commit that referenced this issue Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants