Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache hit ignored for 304 response #17

Closed
Zeblote opened this issue Sep 8, 2022 · 2 comments
Closed

Cache hit ignored for 304 response #17

Zeblote opened this issue Sep 8, 2022 · 2 comments

Comments

@Zeblote
Copy link

Zeblote commented Sep 8, 2022

Hi, just noticed that you are checking for response.ok() to see if cache was hit. This will fail if cache returned a 304 response to a correct etag.
@kotx
Copy link
Owner

kotx commented Sep 13, 2022

Hey, this should be a simple fix but I'm off for a few days- feel free to implement this yourself if you feel the need, I'll be happy to merge it.

@kotx kotx closed this as completed in 8dc6903 Sep 17, 2022
@kotx
Copy link
Owner

kotx commented Sep 17, 2022

Fixed, but only for 304 responses. LMK if you need some other status code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zeblote @kotx