Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing color on circles #3

Closed
amokan opened this issue Nov 16, 2015 · 3 comments
Closed

tracing color on circles #3

amokan opened this issue Nov 16, 2015 · 3 comments

Comments

@amokan
Copy link

amokan commented Nov 16, 2015

I'm colorblind and cannot for the life of me tell the difference between a node in 'tracing' mode vs not. I had to dig through the code to figure it out because I thought I was losing my mind after looking at your gifs in action :)

Any chance you'd be interested in making the color difference more obvious? I can throw together a pull request, but you may not want me choosing colors.

Awesome tool, though!

@koudelka
Copy link
Owner

Hey there, thanks. :)

I'd love to help you out, but I'm afraid it'd be the (color)blind leading the (color)blind, I'm strong protan. I just borrowed the color palate from a d3 example.

The red is what I assumed that normal eyeballs would be able to see. I actually thought that some of the display code was wrong, too, since I couldn't pick out the red either. I think I wasted about twenty minutes on constant wtf'ing, trying to figure out what I'd done wrong.

I'm totally down to change the colors if you'd like to get a new palate from a non-malfunctining set of biological spectrometers. :)

@amokan
Copy link
Author

amokan commented Nov 20, 2015

@koudelka haha. well, i'll see if I can get someone to glance at this with me and give me some color feedback and I'll toss a PR your way when I get a chance.

Thanks!

@koudelka
Copy link
Owner

sounds good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants