-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons not proper in Arabic mode #84
Comments
@farooq023 it is happening due to missing RTL support in the package. I have added the change in my latest PR. |
I am not using RTL/LTR in my project anywhere. I am just localizing, which is itself doing the RTL/LTR. Will your solution work for me? |
Yeah, it will work for that case. i tested by just setting the language to arabic in supportedLocales |
Alright, thanks a lot. Is your commit merged now? When can I update the package? |
You can update once the repo maintainer approves my changes, till then if you want you can use my fork link in pubspec for a fix |
I removed the previous package & added your fork link in pubspec file, and the problem is still there. |
Can you show me the code you are using specifying localisation and the elegant notification? |
@farooq023 are you by any chance using the main branch from my repo? The code is in rtl branch. |
Thanks a lot, I added the branch name & it's solved now. |
You're welcome. Happy to help 🙌 |
Thanks @farooq023 for filling the issue |
Thanks @koukibadr. Happy to contribute to this awesome package ✨ |
The app I am building has localization of 2 languages, English & Arabic. Both of the icons in the notification are not aligned properly in Arabic mode. Kindly see the SS attached. This issue occurs only in Arabic mode, not in English mode.
The text was updated successfully, but these errors were encountered: