Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons not proper in Arabic mode #84

Closed
farooq023 opened this issue May 8, 2023 · 14 comments · Fixed by #85
Closed

Icons not proper in Arabic mode #84

farooq023 opened this issue May 8, 2023 · 14 comments · Fixed by #85

Comments

@farooq023
Copy link

Screenshot_1683526465

The app I am building has localization of 2 languages, English & Arabic. Both of the icons in the notification are not aligned properly in Arabic mode. Kindly see the SS attached. This issue occurs only in Arabic mode, not in English mode.

@shatanikmahanty
Copy link
Contributor

@farooq023 it is happening due to missing RTL support in the package. I have added the change in my latest PR.

@farooq023
Copy link
Author

I am not using RTL/LTR in my project anywhere. I am just localizing, which is itself doing the RTL/LTR. Will your solution work for me?

@shatanikmahanty
Copy link
Contributor

Yeah, it will work for that case. i tested by just setting the language to arabic in supportedLocales

@farooq023
Copy link
Author

Alright, thanks a lot. Is your commit merged now? When can I update the package?

@shatanikmahanty
Copy link
Contributor

shatanikmahanty commented May 9, 2023

Alright, thanks a lot. Is your commit merged now? When can I update the package?

You can update once the repo maintainer approves my changes, till then if you want you can use my fork link in pubspec for a fix

https://github.com/shatanikmahanty/Elegant-Notification/

@farooq023
Copy link
Author

I removed the previous package & added your fork link in pubspec file, and the problem is still there.

@shatanikmahanty
Copy link
Contributor

I removed the previous package & added your fork link in pubspec file, and the problem is still there.

Can you show me the code you are using specifying localisation and the elegant notification?

@shatanikmahanty
Copy link
Contributor

@farooq023 are you by any chance using the main branch from my repo? The code is in rtl branch.

@farooq023
Copy link
Author

elegant_noti Please view the SS attached.

@shatanikmahanty
Copy link
Contributor

shatanikmahanty commented May 10, 2023

elegant_noti Please view the SS attached.

Please add below url the branch name.

ref: rtl

PS: I have also merged the branch into my Forks main, so your previous import should also work

@farooq023
Copy link
Author

Thanks a lot, I added the branch name & it's solved now.
Alright, I will remove the branch name.
I can use the package from your git link until the package is updated in pub.dev.

@shatanikmahanty
Copy link
Contributor

Thanks a lot, I added the branch name & it's solved now.
Alright, I will remove the branch name.
I can use the package from your git link until the package is updated in pub.dev.

You're welcome. Happy to help 🙌

@koukibadr
Copy link
Owner

Thanks @farooq023 for filling the issue
@shatanikmahanty amazing job !
the new version is available in pub.dev (1.10.0)

@shatanikmahanty
Copy link
Contributor

Thanks @farooq023 for filling the issue
@shatanikmahanty amazing job !
the new version is available in pub.dev (1.10.0)

Thanks @koukibadr. Happy to contribute to this awesome package ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants