Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Generate memory flamegraph with inferno #20

Closed
pothos opened this issue Jun 25, 2019 · 4 comments
Closed

Idea: Generate memory flamegraph with inferno #20

pothos opened this issue Jun 25, 2019 · 4 comments

Comments

@pothos
Copy link

pothos commented Jun 25, 2019

Hello,
maybe the most things for this are already in place and it's easy to do.
Currently manual usage of the heaptrack GUI is needed to see the memory flamegraph. Inferno could be used to directly generate an interactive SVG by exporting a perf-compatible text format (the text format can even be without collapsed stacks, as there is the inferno-collapse-perf command for that).

@koute
Copy link
Owner

koute commented Jun 25, 2019

The profiler already uses inferno and can already generate flamegraphs. (: You just need to use the server subcommand to be able to access that functionality. (You can either access it through the GUI, or through the REST API.)

@koute koute closed this as completed Jun 25, 2019
@pothos
Copy link
Author

pothos commented Jun 26, 2019

Yes, I saw them for leaked allocations but did not realize that I could change /data/…/export/flamegraph/flame.svg?lifetime=only_leaked to /data/…/export/flamegraph/flame.svg. So it's just a matter of having a link in the UI?

@koute
Copy link
Owner

koute commented Jun 26, 2019

So it's just a matter of having a link in the UI?

There is a link in the UI. (: When you browse through the allocations you can click in the upper right corner to access a menu with a link to a flamegraph. (I might replace that menu with a sidebar in the future so that it's more obvious.)

@pothos
Copy link
Author

pothos commented Jun 26, 2019

Ah :) Yes, similar to the leaked-allocation flamegraph link such a link could be displayed behind All allocations as well. Anyway, thanks for the reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants