Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty vehicleType causes empty response. #34

Closed
cbrherms opened this issue Feb 13, 2019 · 2 comments
Closed

empty vehicleType causes empty response. #34

cbrherms opened this issue Feb 13, 2019 · 2 comments
Labels

Comments

@cbrherms
Copy link
Contributor

"vehicleType": self.vehicle_type,

^ This being empty when vehicle_type is not defined causes an empty response. If it is included in the sent params it must contain a valid type of 'PRIVATE', 'TAXI', 'MOTORCYCLE', or 'ELECTRIC' (US and Canada region only).
source

cbherms@Herms-PC:/mnt/d/Documents/GitHub/WazeRouteCalculator$ python example.py
From: Budapest, Hungary - to: Győr, Hungary
empty response

Admittedly I was unaware private and electric were accepted values, hence setting it to taxi, though i now also realise using taxi instead of private would skew routes as they can use bus lanes in some countries.

Either way, setting it to 'PRIVATE' if it is undefined will fix the above issue, unless you wish to have a check to see if the variable contains anything.
Also, including the full list of options including the note for Electric would be useful to others.

@kovacsbalu
Copy link
Owner

Thanks @cbrherms, I will fix it immediately.

@kovacsbalu kovacsbalu added the bug label Feb 14, 2019
@kovacsbalu
Copy link
Owner

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants