Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Europe address_to_coords issue #38

Closed
eleonorapeck opened this issue Mar 20, 2019 · 18 comments
Closed

Europe address_to_coords issue #38

eleonorapeck opened this issue Mar 20, 2019 · 18 comments

Comments

@eleonorapeck
Copy link

Hi,
it seems to me that the 'address_to_coords' returns incorrect coordinates (I used Italian addresses). I think it depends on the 'EU' COORD_SERVERS: if I use 'SearchServer/mozi' instead of 'row-SearchServer/mozi' it seems to work correctly.
Let me know if you agree.

Thank you very much,
Eleonora

@Petro31
Copy link
Contributor

Petro31 commented Mar 27, 2019

I can confirm this. As well as many home assistant users.

@kovacsbalu
Copy link
Owner

Hi @eleonorapeck, can you please give some example?

@eleonorapeck
Copy link
Author

Hi @kovacsbalu , you can try with the following address
'BOLANO, VIA ITALIA 66'
It returns the following (wrong) coordinates:
{'lat': 47.501262664, 'lon': 19.053106307, 'bounds': {}}

It seems it really depends on the region initial coords (that are centered in Budapest if I remember correctly) so it finds a Bulgarian address.

Thank you!

@Mariusthvdb
Copy link

just to give this some more weight Ill add my +1

this used to work just fine:

# https://www.home-assistant.io/components/sensor.waze_travel_time/
  - platform: waze_travel_time
    name: Waze Amsterdam-Roosendaal
    origin: Amsterdam, NL
    destination: Roosendaal, NL
    region: 'EU'

but now results in these Waze errors:

2019-04-15 23:19:44 ERROR (SyncWorker_18) [homeassistant.components.waze_travel_time.sensor] Error on retrieving data: Cannot get coords for Amsterdam, NL
2019-04-15 23:24:46 ERROR (SyncWorker_1) [homeassistant.components.waze_travel_time.sensor] Error on retrieving data: Cannot get coords for Amsterdam, NL
2019-04-15 23:34:47 ERROR (SyncWorker_15) [homeassistant.components.waze_travel_time.sensor] Error on retrieving data: Cannot get coords for Amsterdam, NL
2019-04-15 23:44:54 ERROR (SyncWorker_6) [homeassistant.components.waze_travel_time.sensor] Error on retrieving data: Cannot get coords for Amsterdam, NL

please see if you can return the functionality

@kovacsbalu
Copy link
Owner

kovacsbalu commented Apr 16, 2019

@Mariusthvdb try with full name:

From: Amsterdam, Netherlands - to: Roosendaal, Netherlands
Time 54.45 minutes, distance 69.70 km.

BTW you should check addresses on https://www.waze.com/livemap

@kovacsbalu
Copy link
Owner

@eleonorapeck you can fix with adding country. Try this:

From: Italy, Bolano, Via Italia 66 - to: Italy, La Spezia, Porto Mirabello
{'lat': 44.163387298583984, 'lon': 9.88122272491455, 'bounds': {}}
{'lat': 44.10076141357422, 'lon': 9.82806396484375, 'bounds': {}}
Time 21.57 minutes, distance 10.45 km.

@kovacsbalu
Copy link
Owner

kovacsbalu commented Apr 16, 2019

WazeRouteCalculator use address to coords like waze.com/editor. Maybe need to check live maps solution.

@Mariusthvdb
Copy link

Mariusthvdb commented Apr 18, 2019

@kovacsbalu
thanks.
Just noticed that my Homeassistant instance 84.3 reads the Waze_travel_time coordinates perfectly fine...

it's my HA 91.2 set-up causing the issues. So either the component in HA has changed something incorrectly or the full update caused things to go awol
Maybe @Petro31 knows more about this?

have a look:

HA 84.3
Schermafbeelding 2019-04-18 om 22 07 51

and HA 91.2:

Schermafbeelding 2019-04-18 om 22 08 37

with the exact same setup, as provided a few post above.

@Petro31
Copy link
Contributor

Petro31 commented May 16, 2019

Nothing can be done. I put in a PR against home assistant back in march and it hasn't been merged. You're welcome to use it as a custom component. You can also just use the 84.3 version as a custom component. Either way, my hands are tied in the matter.

@hmmbob
Copy link
Contributor

hmmbob commented May 16, 2019

The Home Assistent pull request has the "in progress" label still attached to it (probably falsely). Items with "in progress" are filtered when the developers select PRs for the updates - hence your PR was likely never seen.

It also has some branch issues by now - maybe solve those to get the label removed, and/or try opening a new PR (again .....).

(I'm no dev, just noting my observations)

@Petro31
Copy link
Contributor

Petro31 commented May 16, 2019

Ah, I did not know that. I only dev for them once and a while. Partly because of issues like this. I'll see if I can remove the in process flag and clear the merge issues. They are minor and i'm not even sure why they are coming up as none of the files cross with the recent changes. Probably some safety precaution.

@Mariusthvdb
Copy link

@Mariusthvdb try with full name:

From: Amsterdam, Netherlands - to: Roosendaal, Netherlands
Time 54.45 minutes, distance 69.70 km.

BTW you should check addresses on https://www.waze.com/livemap

sorry I forgot to get back on this...

I did change to the full names, and indeed it returns a distance now, but it completely incorrect.. Which is rather awkward since there are no other cities with the same name....

tried it in Dutch (as the website does) but that is not recognized...

All in all, it is a pity we can't simply calculate the travel time between 2 cities (by name) ,( or a city and a device or gs coordinate for that matter), directly.

would this be enhanced in the near future?

@CrappyTan
Copy link

I've just started seeing these errors too.
I have 3 checks - it seems that the UK post codes are having a problem being found. From my house to W14 9YW is apparently 197km. It's only around 30. To another postcode, SW1X 7XL, it complains it cannot find the coords for it.

Has waze changed something that is causing this?

@kovacsbalu
Copy link
Owner

kovacsbalu commented Jul 11, 2019

Hi @CrispinP, @Mariusthvdb can you please show and example? Please try to check your addresses on waze live map.

@CrappyTan
Copy link

@kovacsbalu
Postal address on the live map works but Waze converts / suggests a slightly better address; it prefixes it with London.
If I put the full address in then it works ok.

I don't think this is your error or anything you can change. In the UK post codes are pretty exact and it should work. Waze is decoding the address wrong.

Solution: Put the full address in and it works :)

Thank you for the tool 👍

@CrappyTan
Copy link

ok, scratch that. There is something funky going on. The exact address, no matter what I use, is landing somewhere odd. See screen grab below
image

Here is what google thinks: https://www.google.co.uk/maps/dir/SG14+1PB/W14+9YW/@51.6445848,-0.3667965,11z/data=!3m1!4b1!4m13!4m12!1m5!1m1!1s0x48762692f12f5a4f:0xdcfad6fbbd03a083!2m2!1d-0.07319!2d51.7979558!1m5!1m1!1s0x48760fc1cc1442a3:0xde8b517811c6590a!2m2!1d-0.212513!2d51.4967339

Very odd.

@kovacsbalu
Copy link
Owner

kovacsbalu commented Jul 22, 2019

@CrispinP check this:

From: SG14 1PB, Bluecoats Ave, Hertford, UK - to: W14 9YW, Hammersmith, London, UK
Time 81.48 minutes, distance 47.80 km.
From: SG14 1PB - to: W14 9YW
Time 164.23 minutes, distance 188.32 km.

Google map also extend your addresses.

@CrappyTan
Copy link

I wonder why they no longer resolve the postcode to an exact address. Moreso, I wonder to where this postcode is resolved.

I guess this is not your problem or anything you can control.

thanks for the time and effort.

C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants