Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the current tab color #1287

Closed
octplane opened this issue Jan 4, 2019 · 5 comments
Closed

Changing the current tab color #1287

octplane opened this issue Jan 4, 2019 · 5 comments

Comments

@octplane
Copy link

octplane commented Jan 4, 2019

Hello,

thanks for kitty!

Would you be interested in adding a command to change permanently the current tab color? I use a small app to color my iTerm tabs and was looking for a way to do the same in kitty. If you can point me at some code, I'll gladly try and add the feature.

@kovidgoyal
Copy link
Owner

seems somewhat odd using an escape code for that. A tab can have more than one window, so either:

  1. last color received by some window in the tab wins
  2. the color set by the current active window is used

(1) is easier to implement, (2) is more correct.

If you want to implement it, you would first need to implement anew escape code for it, probably something under the DCS namespace with the @ key, look in parser.c for dispatch_dcs()

then add a handler to store the requested color in window.py. Then implement using that color in tabs.py and tab_bar.py

@erf
Copy link

erf commented Jan 4, 2019

What about giving an initial array of colors, one per tab, in the order listed?

@kovidgoyal
Copy link
Owner

Oh and for ease of use there should really be an interface for this in kitty remote control as well, since presumably escape codes will only be allowed to change the color of the current tab.

@giftig
Copy link

giftig commented Jan 11, 2019

I think option (1) is actually pretty reasonable if you consider the tab colour as belonging to the tab, not belonging to the window (which seems fair enough since it's the colour of the tab itself).

@securisec
Copy link

@kovidgoyal are you releasing this feature in an upcoming release or is it nightly releases from now on? Asking because 0.23.1 was a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants