Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support For Fira Code 2 #1969

Closed
mildlyincompetent opened this issue Sep 14, 2019 · 1 comment
Closed

Support For Fira Code 2 #1969

mildlyincompetent opened this issue Sep 14, 2019 · 1 comment

Comments

@mildlyincompetent
Copy link

mildlyincompetent commented Sep 14, 2019

I'm aware that kitty used to support Fira Code (and indeed Fira Code was used to develop ligature support in kitty and used to work out of the box in kitty, as described in #827)

Since Fira Code as of version 2 has spacing=90, which means kitty does not recognise it as a monospace font (as I understand it this is the issue), so kitty no longer works with or supports Fira Code.

I'm wondering if there is a plan to add support for Fira Code or if, due to these recent changes, Fira Code will no longer be supported by kitty?

I note that a similar issue arose with the Iosevka font in #179, where the conclusion was that Iosevka is not a monospace font, but its Term and TermLig versions are indeed monospace, and the latter supports ligatures. To my knowledge there is no (current) version of Fira Code that has both true monospace (i.e. spacing=100) and ligatures, so a possible (probably best) solution would be to somehow modify Fira Code in a similar way to Iosevka's TermLig, adding true monospace to the ligatured font, but I am curious if this could be resolved in kitty or if supporting non spacing=100 fonts is just not possible?

@mildlyincompetent
Copy link
Author

Never mind, just discovered that #1968 is effectively a duplicate of this, apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant