Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: a very long terminal title will fill up all the menubar #2132

Closed
minusf opened this issue Nov 13, 2019 · 12 comments
Closed

macOS: a very long terminal title will fill up all the menubar #2132

minusf opened this issue Nov 13, 2019 · 12 comments

Comments

@minusf
Copy link

minusf commented Nov 13, 2019

In the window title I think it's fine to take up all the space but it looks a bit strange in the menubar:

Screenshot 2019-11-14 at 00 21 36

Perhaps some limit (64 chars?) followed by ...?

@kovidgoyal
Copy link
Owner

Whats wrong with taking up the space, if needed? Does it prevent something being used in the menubar?

@minusf
Copy link
Author

minusf commented Nov 14, 2019

i think a limit would be useful as i have a lot of information in my menubar: battery, clock, sound, cpu load, disk activity, etc. as you can see in the screenshot the full title still didnt fit, so it's cut off at some point anyway.

@kovidgoyal
Copy link
Owner

Yeah what I am asking is, does the long title push off this information? I would have thought coca would truncate menu items that dont fit before they interfere with other widgets on the menu bar.

@Luflosi
Copy link
Contributor

Luflosi commented Nov 14, 2019

macOS removes the items on the right until the stuff on the left fits. But I'm not sure truncating the information is a good idea because we don't know how long it should be. There can be arbitrarily many items on the right and unless there is some way to query how much space those items take up, it's difficult deciding on one particular length that works for everybody.

@minusf
Copy link
Author

minusf commented Nov 14, 2019

as you can see on the screenshot, it fills it up to the edge. the screenshot is from "wall to wall". i was also suprised that the OS gives up all this place for the menubar :}

macOS removes the items on the right until the stuff on the left fits. But I'm not sure truncating the information is a good idea because we don't know how long it should be. There can be arbitrarily many items on the right and unless there is some way to query how much space those items take up, it's difficult deciding on one particular length that works for everybody.

the information is already truncated as it simply does not fit in this example. the menubar is normally for menu items and not variable length information items like this and while i like the way it is being abused, i think it would be more useful to have a maximum width with an ellipsis (which already happens at the edge in this example). i personally would not expect more information to be shown than what is shown with a "standard" 80x24 terminal window title, which depending on the text (not monospace font) is around 60-90 characters.

@kovidgoyal
Copy link
Owner

kovidgoyal commented Nov 14, 2019 via email

@minusf
Copy link
Author

minusf commented Nov 14, 2019

i also see that it is not being updated correctly all the time when an external monitor is attached. even if a different terminal is active, the previous active terminal's title is shown in the menubar...

@minusf
Copy link
Author

minusf commented Nov 18, 2019

(for the record i have now switched to macos_show_window_title_in window and i am happy with it)

@wyuenho
Copy link

wyuenho commented Jan 31, 2022

Now that we are in 2022, I just want to say, on the M1 Pro MBPs, any terminal title longer than a couple of words will be shifted entirely to the right of the screen due to the notch leaving the left side still empty, so the end result is neither the space can be efficiently filled up nor the terminal title on the menu readable lol.

I'm glad there's a configuration for it tho, it should be the default on M1 Pro MBPs.

@Techcable
Copy link

Techcable commented Feb 2, 2022

For some reason, this appears fixed for my as of the latest commit (43ceaf0).

I didn't change my config files or anything. It just appears on the left of the menu bar now (right next to "Shell", "Window", "Help").

screenshot

Can someone else please confirm this is fixed (on nightly)?

@toonn
Copy link
Contributor

toonn commented Feb 7, 2022

@Techcable, do you mean to the left of the notch? Because that's the issue described by wyuenho.

I'm on a rather large display so I appreciate there not being a hardcoded limit. If a limit is decided upon I'd like to request it be configurable.

@Techcable
Copy link

@Techcable, do you mean to the left of the notch? Because that's the issue described by wyuenho.

No. I mean it's gone from the right side of the screen to the left side. I have "kitty. Shell", "Window", "Help", on the left side.

Then I have a large space, then I have the items normally in my right menu bar.

This change seems to come between 0.24.1 and 0.24.2. I did not edit my config at all. It just moved.

I'm on a rather large display so I appreciate there not being a hardcoded limit. If a limit is decided upon I'd like to request it be configurable.

I don't know if they added any sort of limit. For me the problem has effectively gone away because the window name has moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants