Very dim colours in 0.17.0

[lithammer]

After upgrading to v0.17.0 on macOS Catalina 10.15.3, the colours are super dim.

v0.16.0

v0.17.0

[lithammer]

After bisecting my config bit, it seems like it's related to the font_family setting. It's mostly Iosevka that looks this bad, the default monospace looks fine for example.

[kovidgoyal]

I cant think of any changes in 0.17 that affect font rendering. Can you bisect to find the problem commit?

[lithammer]

I tried to bisect with git bisect start v0.17.0 v0.16.0 --. Unfortunately I had to skip a bunch of commits that either didn't build, didn't start or didn't use the correct font (used a fallback font?).

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
ac2c21e
c817ba9
3c2f3ec
92827ae
5bdb405
7298de6
7d690bb
9beae32
353db67
abff229
8ae1106
9b973ef
308d171
f74fb84
d8f214a
We cannot bisect more!

Here's the complete log:

# bad: [93271b9] version 0.17.0
# good: [644ee64] version 0.16.0
git bisect start 'v0.17.0' 'v0.16.0' '--'
# skip: [e03aabd] Some consting
git bisect skip e03aabd
# skip: [5bbc155] Non-scrolling based selection tests all pass
git bisect skip 5bbc155
# good: [f729985] More typing work
git bisect good f729985
# bad: [b27f6d5] more typing work
git bisect bad b27f6d5
# skip: [3c2f3ec] Fix #2420
git bisect skip 3c2f3ec
# skip: [ac2c21e] more typing work
git bisect skip ac2c21e
# good: [645890c] Make the set of URL prefixes that are recognized while hovering with the mouse configurable
git bisect good 645890c
# bad: [d8f214a] oops
git bisect bad d8f214a
# skip: [92827ae] More typing work
git bisect skip 92827ae
# skip: [c817ba9] more typing work
git bisect skip c817ba9
# skip: [308d171] More typing work
git bisect skip 308d171
# skip: [5bdb405] More typing work
git bisect skip 5bdb405
# skip: [abff229] Workaround for sphinx type info being available magically on the CI server
git bisect skip abff229
# skip: [9beae32] More typing work
git bisect skip 9beae32
# skip: [9b973ef] More typing work
git bisect skip 9b973ef
# skip: [353db67] Add typing to box_drawing
git bisect skip 353db67
# skip: [8ae1106] More typing work
git bisect skip 8ae1106
# skip: [7298de6] more typing work
git bisect skip 7298de6
# good: [7057bc6] Implement proper editor integration for mypy
git bisect good 7057bc6
# skip: [7d690bb] Run mypy on CI
git bisect skip 7d690bb
# skip: [f74fb84] Fix #2421
git bisect skip f74fb84
# only skipped commits left to test
# possible first bad commit: [d8f214a] oops
# possible first bad commit: [f74fb84] Fix #2421
# possible first bad commit: [8ae1106] More typing work
# possible first bad commit: [abff229] Workaround for sphinx type info being available magically on the CI server
# possible first bad commit: [7d690bb] Run mypy on CI
# possible first bad commit: [7298de6] more typing work
# possible first bad commit: [3c2f3ec] Fix #2420
# possible first bad commit: [ac2c21e] more typing work
# possible first bad commit: [c817ba9] more typing work
# possible first bad commit: [92827ae] More typing work
# possible first bad commit: [5bdb405] More typing work
# possible first bad commit: [9beae32] More typing work
# possible first bad commit: [353db67] Add typing to box_drawing
# possible first bad commit: [9b973ef] More typing work
# possible first bad commit: [308d171] More typing work

[kovidgoyal]

Which Iosevka variant are you using? I will try to reproduce.

[lithammer]

Thanks. I'm currently 02-iosevka-fixed-3.0.0-rc.4.zip. I know it's a release candidate, but I could also reproduce with the stable 02-iosevka-term-2.3.3.zip release (however it's slightly better).

Note that in the release candidate iosevka-term was renamed to iosevka-fixed and a new package iosevka-term was introduced that contains ligatures.

[kovidgoyal]

Which variant are you using? As in what is the value of font_family in kitty.conf and what does kitty --debug-font-fallback say about which font is selected? On linux with

kitty --config NONE -o font_family=Iosevka\ Fixed

it works fine. Dont have access to macOS at the moment to test there

[lithammer]

Which variant are you using? As in what is the value of font_family in kitty.conf

font_family      Iosevka Fixed
bold_font        auto
italic_font      auto
bold_italic_font auto

what does kitty --debug-font-fallback say about which font is selected?

v0.16.0

[084 13:19:57.583526] Preloaded font faces:
[084 13:19:57.583560] normal face: {'monospace': True, 'bold': False, 'italic': False, 'family': 'Iosevka Fixed'}
[084 13:19:57.583576] bold face: {'monospace': True, 'bold': True, 'italic': False, 'family': 'Iosevka Fixed'}
[084 13:19:57.583588] italic face: {'monospace': True, 'bold': False, 'italic': True, 'family': 'IosevkaFixed'}
[084 13:19:57.583601] bi face: {'monospace': True, 'bold': True, 'italic': True, 'family': 'Iosevka Fixed'}

v0.17.0

./kitty --config NONE -o font_family=Iosevka\ Fixed --debug-font-fallback
[084 13:17:47.255557] Preloaded font faces:
[084 13:17:47.255620] normal face: /Users/peter/Library/Fonts/iosevka-fixed-extendedthin.ttf
[084 13:17:47.255645] bold face: /Users/peter/Library/Fonts/iosevka-fixed-extendedbold.ttf
[084 13:17:47.255666] italic face: /Users/peter/Library/Fonts/iosevka-fixed-oblique.ttf
[084 13:17:47.255686] bi face: /Users/peter/Library/Fonts/iosevka-fixed-extraboldoblique.ttf

It seems like it's picking up the 'thin' variant instead of 'regular'.

[kovidgoyal]

Should be fine in master.