Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to prevent unintended close #2857

Closed
smolin opened this issue Jul 15, 2020 · 3 comments
Closed

option to prevent unintended close #2857

smolin opened this issue Jul 15, 2020 · 3 comments

Comments

@smolin
Copy link

smolin commented Jul 15, 2020

kitty is wonderful, thank you very much!

Is your feature request related to a problem? Please describe.
I'm always frustrated when I hit command-q or command-w and the window closes, losing my shell state.

Describe the solution you'd like
I would like a dialog open asking "do you really want to close this window? yes/no"

Describe alternatives you've considered
Um ... I've looked through the docs and issues and didn't see this as an option?

Additional context
Add any other context or screenshots about the feature request here.
MacOS 10.14.6, kitty 0.17.4

@Luflosi
Copy link
Contributor

Luflosi commented Jul 15, 2020

@smolin
Copy link
Author

smolin commented Jul 15, 2020

Thanks Luflosi! I shoulda updated first of course.

This is almost but not quite perfect - set to "1" it:

- confirms closing the application with command-q
- confirms closing windows when clicking on the red X circle button
- confirms closing windows with command-w when there are more than one shell

but it does not confirm closing a window with command-w when there is only one shell. The description says "at least this number of kitty windows" so I think it's not counting correctly....

@kovidgoyal
Copy link
Owner

As I recall cmd+w is close_tab, correct? The option is for closing OS windows, not tabs. It might make sense to either extend it to also apply to tabs or to have a new option for tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants