Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase accented characters are off with Fira Code #2985

Closed
blehel opened this issue Sep 30, 2020 · 6 comments
Closed

Uppercase accented characters are off with Fira Code #2985

blehel opened this issue Sep 30, 2020 · 6 comments
Labels

Comments

@blehel
Copy link

blehel commented Sep 30, 2020

The baseline of uppercase accented characters is off when using the font Fira Code.
This seems to affect only the font sizes 12 and 13.

For example, if I write "ÁRVÍZTŰRŐ TÜKÖRFÚRÓGÉP" at the prompt, this is what I get:
fira-kitty

Compare this to a libvte-based terminal emulator:
fira-terminator

debug-config output:

kitty 0.18.3 created by Kovid Goyal
Linux aurora 5.8.9_1 #1 SMP Sun Sep 13 21:10:27 UTC 2020 x86_64
Void \r (\n) (\l)
Loaded config files: /home/blehel/.config/kitty/kitty.conf
Running under: X11

Config options different from defaults:
bold_font                  Fira Code Medium
color1                     Color(red=205, green=0, blue=0)
color10                    Color(red=0, green=238, blue=0)
color11                    Color(red=255, green=255, blue=0)
color12                    Color(red=0, green=0, blue=255)
color13                    Color(red=255, green=0, blue=255)
color14                    Color(red=0, green=205, blue=205)
color2                     Color(red=0, green=205, blue=0)
color3                     Color(red=205, green=205, blue=0)
color4                     Color(red=0, green=0, blue=168)
color5                     Color(red=205, green=0, blue=205)
color6                     Color(red=0, green=168, blue=168)
color7                     Color(red=168, green=168, blue=168)
color8                     Color(red=84, green=84, blue=84)
color9                     Color(red=255, green=0, blue=0)
cursor                     Color(red=0, green=255, blue=0)
disable_ligatures          1
font_family                Fira Code
font_features              {'FiraCode-Regular': ('+ss03', '+ss05', '+ss07'), 'FiraCode-Medium': ('+ss03', '+ss05', '+ss07')}
font_size                  13.0
foreground                 Color(red=168, green=168, blue=168)
mouse_hide_wait            0.0
pointer_shape_when_grabbed hand
strip_trailing_spaces      smart
Added shortcuts:
	 shift+f12 KeyAction(func='paste_from_selection', args=())
	 shift+control+space KeyAction(func='new_os_window_with_cwd', args=())

@blehel blehel added the bug label Sep 30, 2020
@Luflosi
Copy link
Contributor

Luflosi commented Sep 30, 2020

Also see #2086.

@kovidgoyal
Copy link
Owner

Use adjust_line_height in kitty.conf. presumably whatever font those
characters are coming from has metrics not compatible with your main
font.

@trygveaa
Copy link
Sponsor Contributor

This isn't about different metrics for different fonts, it happens even when all the characters are coming from Fira Code.

@kovidgoyal
Copy link
Owner

Then Fira Code doesnt report correct metrics, kitty simply uses the
reported font metrics to calculate cell height, see calc_cell_height()

@charbelnicolas
Copy link

This is still an issue with kitty in 2023. Xterm and alacritty work fine.

Alacritty:
20230729_174741

Xterm:
20230729_174802

Kitty:
20230729_174755

This is using Iosevka latest version from github.

@charbelnicolas
Copy link

This is still an issue with kitty in 2023. Xterm and alacritty work fine.

Alacritty: 20230729_174741

Xterm: 20230729_174802

Kitty: 20230729_174755

This is using Iosevka latest version from github.

This issue is now magically resolved for me today :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants