Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard expansion in kitty.conf include doesn't work #4533

Closed
glibg10b opened this issue Jan 18, 2022 · 5 comments
Closed

Wildcard expansion in kitty.conf include doesn't work #4533

glibg10b opened this issue Jan 18, 2022 · 5 comments

Comments

@glibg10b
Copy link

Is your feature request related to a problem? Please describe.
kitty.conf: include kitty.d/**/*.conf doesn't include anything. I'd like it to include all *.conf files under kitty.d and subdirectories recursively

Describe the solution you'd like
Parse globs just like bash does (** requires shopt -s globstar in bash)

Additional context
Relevant function:

def parse_line(

@page-down
Copy link
Contributor

I think this needs a new configuration option.

Currently include *.conf loads the file *.conf correctly, and changing this would break backwards compatibility.

@kovidgoyal
Copy link
Owner

I dont see a need for this. You will need to explain your use case in
more detail.

@glibg10b
Copy link
Author

glibg10b commented Jan 18, 2022

@kovidgoyal Having one include *.conf that includes all .conf files in a directory is nice (vim and zsh allow it)

Having to do this instead is annoying and requires maintenance

@kovidgoyal
Copy link
Owner

My question was not why using a glob pattern is better than including individual files, it was why are you splitting your conf file into so many individual files. And in any case this is already implemented, see the commit that closed the issue.

@glibg10b
Copy link
Author

It's just more organized this way: finding the settings I'm looking for is easier, and so is sharing or deleting e.g. only my color theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants