Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are no tests for Chapter 3 #124

Closed
OxSon opened this issue Oct 6, 2020 · 3 comments
Closed

There are no tests for Chapter 3 #124

OxSon opened this issue Oct 6, 2020 · 3 comments
Labels
question Further information is requested tests Testing, property testing, DocTests

Comments

@OxSon
Copy link

OxSon commented Oct 6, 2020

Neither DoctestChapter3.hs nor test/Test/Chapter3.hs contain any tests.

@chshersh chshersh added question Further information is requested tests Testing, property testing, DocTests labels Oct 6, 2020
@chshersh
Copy link
Contributor

chshersh commented Oct 6, 2020

Hi @OxSon! Yeah, test suite for Chapter Three is not implemented, because not much we can test in there... We expect people to implement data types, and this process is connected with imagination. People will name data types differently, and tests simply won't compile if names mismatch. Moreover, we want people to define data types from scratch, and tests that using those data types won't even compile without data types.

If you have any ideas on what can be tested in there, we can implement some basic and simple tests. But so far, not much can be done 😞 Though I saw that a few people implemented their own tests for this Chapter, and that was pretty awesome! 👏

@OxSon
Copy link
Author

OxSon commented Oct 6, 2020

Ah, that does make sense why there aren't any tests. Because there are many valid solutions to the tasks. I wonder if there could be useful tests using property based testing? I will think on this and see if I can come up with any tests that are useful. Probably I wont though, since I am still haskell newbie and haven't actually used quickcheck and friends

@OxSon
Copy link
Author

OxSon commented Oct 6, 2020

@chshersh probably we can close this issue since my question is answered and the decision to not have tests for chapter 3 was intentional and motivated by as of yet unsolved constraints

@OxSon OxSon closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested tests Testing, property testing, DocTests
Projects
None yet
Development

No branches or pull requests

2 participants