Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement property-based tests for Validation #176

Closed
chshersh opened this issue Jul 29, 2019 · 8 comments · Fixed by #216
Closed

Implement property-based tests for Validation #176

chshersh opened this issue Jul 29, 2019 · 8 comments · Fixed by #216
Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ tests

Comments

@chshersh
Copy link
Contributor

Most important instances that need to be covered:

  1. Applicative
  2. Alternative
  3. Semigroup
  4. Monoid

Also, I've noticed that *> and <* operators are not implemented efficiently, they need to implemented in the style of <*>... So once we have tests we can verify that the implementations are indeed correct.
@chshersh chshersh added the tests label Jul 29, 2019
@chshersh chshersh added this to the v0.6.0.0: Refinement milestone Jul 29, 2019
@chshersh chshersh mentioned this issue Sep 20, 2019
Merged
10 tasks
@vrom911 vrom911 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Sep 29, 2019
@astynax
Copy link
Contributor

astynax commented Oct 2, 2019

Can I take this one?

@chshersh
Copy link
Contributor Author

chshersh commented Oct 2, 2019

@astynax Sure, go for it!

@chshersh
Copy link
Contributor Author

@astynax hi, friendly ping 🙂 How are you doing? Are you stuck on anything? Feel free to ask any questions or clarify any details 🙂

@astynax
Copy link
Contributor

astynax commented Oct 12, 2019

Friendly pong! I'm still playing with Hedgehog, but I'm thinking that I almost grok it :)

@chshersh chshersh removed this from the v0.6.0.0: Refinement milestone Oct 16, 2019
@astynax astynax mentioned this issue Oct 23, 2019
Merged
10 tasks
@astynax
Copy link
Contributor

astynax commented Oct 23, 2019

Sorry for delay, I was pretty sick for more than week :(

@chshersh
Copy link
Contributor Author

@astynax No worries! 🙂

@astynax
Copy link
Contributor

astynax commented Oct 23, 2019

I think I'm done (PR). Or it will be good to check anything else? :)

@chshersh
Copy link
Contributor Author

@astynax Thanks for the work! I will try to review as soon as I can and comment on the PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add property tests for the Validation type
3 participants
@chshersh @astynax @vrom911