Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bugs with Gen.hs #198

Closed
1 of 2 tasks
jiegillet opened this issue Jun 24, 2019 · 2 comments
Closed
1 of 2 tasks

Small bugs with Gen.hs #198

jiegillet opened this issue Jun 24, 2019 · 2 comments
Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed test Testing (unit, properties)

Comments

@jiegillet
Copy link
Collaborator

jiegillet commented Jun 24, 2019

Some bugs I found when running tests:

  • The string "\" can be generated as a key, but is invalid because the escape character cannot be on its own
  • It can generate an array a which contains two arrays b and b.c on the same level, which pretty prints to [[a]] \n [[a.b]] \n [[a.b.c]] but that gets (correctly) interpreted as an array a that contains an array b that contains an array c. Elements of an array can't share prefixes.

The first one should be easy to fix, the second is trickier maybe, but overall those have very small chance of appearing, and if they do, re-running the test has always done the trick for me. Maybe not worth fixing.

@jiegillet jiegillet added bug Something isn't working test Testing (unit, properties) labels Jun 24, 2019
@chshersh
Copy link
Contributor

@jiegillet Let's fix the first problem because it's the easiest one. And keep the issue open. Maybe somebody would like to practice in implementing generators 🙂

@chshersh chshersh removed the bug Something isn't working label Jul 7, 2019
@chshersh chshersh added the help wanted Extra attention is needed label Jul 10, 2019
@vrom911 vrom911 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Sep 29, 2019
@chshersh
Copy link
Contributor

The first part was fixed. The second part will require more effort to fix and it doesn't cause any troubles so far, so I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed test Testing (unit, properties)
Projects
None yet
Development

No branches or pull requests

3 participants