Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please move black to dev-dependencies #60

Closed
bodograumann opened this issue Nov 17, 2020 · 4 comments
Closed

Please move black to dev-dependencies #60

bodograumann opened this issue Nov 17, 2020 · 4 comments
Labels

Comments

@bodograumann
Copy link

You are listing black as a runtime dependency with a fixed version of 19.1b0. Unfortunately that conflicts with the version I want to use 20.8b1.

Afaics black is only used as a development dependency in this project, so it should be marked as such and the conflict would be resolved.

@koxudaxi
Copy link
Owner

@bodograumann
I'm sorry. I lost a notification for this issue.
I want your problem. But, black is fixed in datamodel-code-generator
black>=19.10b0,<20
https://github.com/koxudaxi/datamodel-code-generator/blob/4e4848fb9f03989599b2c8cc957dc30b4496afa3/setup.cfg#L37

We have to change the version of the cap.
Also, I don't know 20.8b1 is compatible with 19.1b0 🤔

@bodograumann
Copy link
Author

I see.
Maybe you could make the code formatting in datamodels-code-generator optional, if the user wants to do their own code-formatting.
Then you could also define black as an optional dependency there.

Apart from that I think you still need to move it to dev-dependencies in fastapi-code-generator.

@koxudaxi
Copy link
Owner

koxudaxi commented Dec 2, 2020

@bodograumann
Copy link
Author

Thank you, this works nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants