Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Marked is incompatible for PyCharm EAP while compatible #179

Closed
BenjaminAfrolabs opened this issue Feb 9, 2021 · 4 comments
Closed

Marked is incompatible for PyCharm EAP while compatible #179

BenjaminAfrolabs opened this issue Feb 9, 2021 · 4 comments
Labels

Comments

@BenjaminAfrolabs
Copy link

BenjaminAfrolabs commented Feb 9, 2021

Describe the bug
Marked is incompatible for PyCharm EAP while compatible

To Reproduce
Steps to reproduce the behavior:

  1. Install pycharm EAP
  2. Install plugin manually (the marketplace will only install 1.0.3 which is broken)
  3. Restart pycharm

Expected behavior
Plugin to work without extra steps

Environments (please complete the following information):

  • IDE: PyCharm Professional 2021.1 (211.4961.30)
  • OS: Windows 10 20H2
  • Poetry Version: 1.1.4
  • Plugin version: 1.0.6

Additional context
Work around is to bump the version up in the plugin.xml file in the installed plugin

Having an unrestricted version available on GitHub would also be appreciated if you want to keep the restriction in the marketplace version

@koxudaxi
Copy link
Owner

koxudaxi commented Feb 9, 2021

@BenjaminAfrolabs
Thank you for creating this issue.
I'm trying to build with 211.4961.22
The result is a failure. some interfaces are changed.
I will change implementations.

@BenjaminAfrolabs
Copy link
Author

Looking forward to an official version, it really has made it easier to manage python/poetry

@koxudaxi
Copy link
Owner

koxudaxi commented Feb 9, 2021

I put related changes
JetBrains/intellij-community@6d9e039
JetBrains/intellij-community@fb7e5d6

Looking forward to an official version, it really has made it easier to manage python/poetry

@BenjaminAfrolabs
Me too. But, now it is not provided :(
They change the interface for SDK in recent versions.
I hope these interfaces will be fixed completely.

Also, I found this commit message in JetBrains/intellij-community@fb7e5d6

I will ask @sproshev about the change.

Refactor quickfix to clean API

No need to have two methods and break nullable safety.

Poetry plugin could be broken by this change, but Semyon.Proshev will send them a patch)

@koxudaxi
Copy link
Owner

@BenjaminAfrolabs
Version 1.1.0 is released, which is for EAP 211. *

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants