-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong sorting of imports #422
Comments
I had this issue when using It seemed that somehow the lsp was not picking up (some of) the options which I set in my I had the following packages installed (managed by Poetry):
Perhaps this could give a starting point for fixing this bug. |
Thanks. As to my setup, ruff-lsp is not used. |
I'm also seeing this behaviour. @hexvolt Did you find a workaround? |
@TimChild Nope, unfortunately I have to live with yellow warning around every import block:( To me, this is clearly a pretty major bug, idk why it is not labeled as such yet |
Happens to me as well. Since my imports are now always out of order, I always have to use the command line as well to fix it before I commit any files :( |
Describe the bug
The sorting of imports is not consistent with ruff CLI output.
The plugin is awesome but when it is enabled, it highlights the imports that are sorted properly by categories. If I reformat the code using the plugin, it rearranges the imports in some weird order (3rd party packages being mixed with the local code packages), which is totally different from what
ruff check --select I --fix
does. So if sort imports properly with the external commandruff check --select I --fix
, then the plugin complains on my imports and tries to rearrange them back.So in order to use the plugin I have to either cope with seeing yellow highlights on all (properly sorted) imports, or give up proper sorting and let plugin do the weird sorting.
To Reproduce
Steps to reproduce the behavior:
ruff check --select I --fix
Expected behavior
The plugin should yield the same results of imports sorting as the official ruff command
ruff check --select I --fix
.Screenshots
You can see how imports sorted properly by the
ruff check --select I --fix
command are highlighted by the plugin with yellow, while it shouldn't.And this is the order plugin thinks is correct but it's not.
Environments (please complete the following information):
Notes:
UPDATE
Noteworthy is that if I remove the reference to the pyproject.toml file in the plugin settings, it does sorting correctly. But in that case it ignores all other settings like line length etc.
The text was updated successfully, but these errors were encountered: