Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV? #10

Closed
palfrey opened this issue May 28, 2022 · 4 comments · Fixed by #11
Closed

MSRV? #10

palfrey opened this issue May 28, 2022 · 4 comments · Fixed by #11

Comments

@palfrey
Copy link
Contributor

palfrey commented May 28, 2022

What's the minimum stable Rust version supported by this library? I've dug through the docs a bit and hadn't spotted any mention of a version.

@kprotty
Copy link
Owner

kprotty commented May 28, 2022

Not sure. How would one go about figuring this out? It requires std::arch::asm stabilization for x86 targets if that helps.

@palfrey
Copy link
Contributor Author

palfrey commented May 28, 2022

Uh, there's probably more sophisticated ways to do so, but for serial_test I mostly just tested with various Rust versions, and then added a CI check to make sure the declared MSRV still kept working.

Although https://doc.rust-lang.org/stable/core/arch/macro.asm.html does say 1.59.0, so that's probably a good place to start :)

@thomcc
Copy link
Contributor

thomcc commented May 28, 2022

Hm, 1.59.0 builds fine. It seems to reliably cause a double-panic issue in the test suite that I thought had only shown up under sanitizers, though.

That probably is just an issue with the test, and not something that impacts actual usage, although I can't say that with total certainty.

@palfrey
Copy link
Contributor Author

palfrey commented May 28, 2022

#11 adds a test/badge for 1.59.0, but I'm also seeing a test issue locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants