Standardize structured function results (ResourceList.results)

[frankfarzan]

• Finalize and publish ResourceList.Results as part of function Spec. A function should still be able to use coarse-grained exit codes to communicate failure.
• Modify TS and Go clients to use the standard. See [1] [2]
• Modify kpt CLI to output the aggregated results as a KRM resource (--results).

[1] https://pkg.go.dev/sigs.k8s.io/kustomize/kyaml/fn/framework/#Result
[2] https://github.com/GoogleContainerTools/kpt-functions-sdk/blob/3232610/ts/kpt-functions/src/types.ts#L375

[Shell32-Natsu]

Should we define the complete result schema in the spec or we just define a results field in the output list? The functionConfig is defined in latter way.

[frankfarzan]

There are two different things:

1. Wire format ResourceList.results, this is not a separate KRM.
2. Output of the kpt CLI FunctionResults which is a KRM.

[droot]

Linking a comment where we discuss confusion about two formats of results: #1923 (comment)

[droot]

@Shell32-Natsu Can you pl. audit both the SDKs and update the status on the second item in the checklist.

[Shell32-Natsu]

@Shell32-Natsu Can you pl. audit both the SDKs and update the status on the second item in the checklist.

Both SDKs are not aligned with the spec.

1. TS SDK
   1. FieldInfo.suggestedValue should be FieldInfo. proposedValue
   2. Result.file.path should be required
   3. Result.resourceRef.namespace should not be required.
   4. Result.severity should not be required.
   5. Severity warn should be warning.
2. Go SDK
   1. Field.SuggestedValue should be Field.ProposedValue.
   2. ResultItem should have Tags.

[droot]

This has been already addressed so closing this.