Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes with index out of range error #1671

Closed
ashlineldridge opened this issue Apr 2, 2021 · 5 comments
Closed

Crashes with index out of range error #1671

ashlineldridge opened this issue Apr 2, 2021 · 5 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists triaged Issue has been triaged by adding an `area/` label

Comments

@ashlineldridge
Copy link
Contributor

Expected behavior

Invalid command line invocations should produce appropriate error messages and not stack traces.

Actual behavior

It's been a while between kpt cfg set calls and I ran the command wrong which produced the stack trace shown below.

> kpt cfg set account-id abc

panic: runtime error: index out of range [2] with length 2

goroutine 1 [running]:
sigs.k8s.io/kustomize/cmd/config/internal/commands.(*SetRunner).preRunE(0xc000970000, 0xc00096cb00, 0xc00093cd80, 0x2, 0x2, 0x0, 0x0)
	sigs.k8s.io/kustomize/cmd/config@v0.9.5/internal/commands/cmdset.go:78 +0x331
github.com/spf13/cobra.(*Command).execute(0xc00096cb00, 0xc00093cd40, 0x2, 0x2, 0xc00096cb00, 0xc00093cd40)
	github.com/spf13/cobra@v1.0.0/command.go:831 +0x523
github.com/spf13/cobra.(*Command).ExecuteC(0xc00094e000, 0x200000003, 0xc000000180, 0xc0007d7f78)
	github.com/spf13/cobra@v1.0.0/command.go:950 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.0.0/command.go:887
main.main()
	github.com/GoogleContainerTools/kpt/main.go:37 +0x65

Information

Kpt version: 0.38.1

@ashlineldridge ashlineldridge added the bug Something isn't working label Apr 2, 2021
@mikebz mikebz added duplicate This issue or pull request already exists triaged Issue has been triaged by adding an `area/` label labels Apr 2, 2021
@mikebz
Copy link
Contributor

mikebz commented Apr 2, 2021

dupe of #1593

@phanimarupaka do we have a patch release of this? I thought this was in .38.1
@runewake2 do you know if you grabbed the dependency update for this?

@mikebz mikebz closed this as completed Apr 2, 2021
@runewake2
Copy link
Contributor

I believe we'd need a new cmd/config release to pick up the fix for this.

@mikebz
Copy link
Contributor

mikebz commented Apr 2, 2021

@runewake2 can you spin one up and create .38.2?

@runewake2
Copy link
Contributor

We could build v0.39.1 after cmd/config is released. I am not able to perform releases in Kustomize though.

@runewake2
Copy link
Contributor

The fix for this should be available in version v0.39.1 of kpt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Development

No branches or pull requests

3 participants