Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACM source, sink, vet functions #581

Open
frankfarzan opened this issue Jan 22, 2020 · 5 comments
Open

Add ACM source, sink, vet functions #581

frankfarzan opened this issue Jan 22, 2020 · 5 comments
Labels
area/fn-catalog Functions Catalog p2 triaged Issue has been triaged by adding an `area/` label

Comments

@frankfarzan
Copy link
Contributor

frankfarzan commented Jan 22, 2020

source: Hydrate ACM repo
vet: Run validations rules
sink: Write configs into ACM repo format

@linde
Copy link
Contributor

linde commented Jan 22, 2020

main concerns here is that it would be nice to be able to supply gcr.io/kpt-functions/write-yaml parameters to name folders so one could respectively:

  • enclose the cluster scoped resources
  • serve as the top level directory in which namespace specific sub-directories are contained

with these two parameters, or an equiv more elegant approach (low bar that!) one would be able to take a kpt resource list and have it written into a configuration root for an ACM repo. this could be handy in a CI step that takes unstructured config from off the shelf tool output or operator manifests and keeps them in sync in an otherwise structured gitops layout.

in the ACM case, if we did it right, this would essentially be the "dehydrate" counterpart to the nomos hydrate sub-command.

@frankfarzan
Copy link
Contributor Author

Agree. I think a good design is to have symmetry between sources and sink, i.e. read-acm-dir/write-acm-dir (Exact name doesn't matter here)

@frankfarzan frankfarzan transferred this issue from GoogleContainerTools/kpt-functions-catalog Apr 29, 2020
@frankfarzan frankfarzan added the area/fn-catalog Functions Catalog label Apr 29, 2020
@frankfarzan frankfarzan added this to the Milestone 2 (Starts 2020-Q2) milestone Apr 29, 2020
@frankfarzan frankfarzan added the triaged Issue has been triaged by adding an `area/` label label May 27, 2020
@frankfarzan frankfarzan changed the title Add ACM source and sink Add ACM source, sink, vet functions Jun 1, 2020
@sankit2020 sankit2020 removed this from the Milestone 2 (Starts 2020-Q2) milestone Jun 24, 2020
@frankfarzan frankfarzan added this to Backlog in Config as Data - Milestone 3 via automation Jun 24, 2020
@monopole monopole moved this from Backlog to Week/30 in Config as Data - Milestone 3 Jul 22, 2020
@prachirp prachirp moved this from Week/30 to Week/32 in Config as Data - Milestone 3 Aug 5, 2020
@prachirp prachirp removed their assignment Aug 5, 2020
@Shell32-Natsu Shell32-Natsu moved this from Week/32 to Week/34 in Config as Data - Milestone 3 Aug 19, 2020
@Shell32-Natsu Shell32-Natsu moved this from Week/34 to Backlog in Config as Data - Milestone 3 Aug 19, 2020
@aw185176
Copy link

aw185176 commented Nov 6, 2020

I am interested in implementing this for our internal usage, but ran into issues because kpt won't allow the path annotation to reference directories. There are quite a few libraries under kyaml and I am not fully up to speed on working with the RNode representation of my document. Assuming that I can write a program which calls Read on the ResourceList passed in via stdin, what would be the easiest path towards writing the individual documents to the file system?

@mikebz mikebz added this to To do in kpt kanban board via automation Nov 12, 2020
@bgrant0607
Copy link
Contributor

cc @janetkuo

@bgrant0607
Copy link
Contributor

For dehydrate, there's https://github.com/dippynark/kfmt

However, we're primarily recommending the unstructured format.

Nonetheless, vet and hydrate would be useful as functions.

@mengqiy mengqiy added the p2 label May 31, 2022
@mengqiy mengqiy removed their assignment May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fn-catalog Functions Catalog p2 triaged Issue has been triaged by adding an `area/` label
Projects
No open projects
Development

No branches or pull requests

8 participants