Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Monkey Patching the Ruby Standard Library #23

Closed
seanbehan opened this issue Jul 10, 2013 · 4 comments
Closed

Avoid Monkey Patching the Ruby Standard Library #23

seanbehan opened this issue Jul 10, 2013 · 4 comments

Comments

@seanbehan
Copy link

Hi,

Thanks for this library. There is a lot of great work here. I have a suggestion though.

There is a lot of monkey patching to the standard library (https://github.com/kputnam/stupidedi/tree/master/lib/ruby) and it is causing breakage for the Rails app I'm working on.

Are you open to the idea of moving away from monkey patching if I submit a patch?

@kputnam
Copy link
Owner

kputnam commented Jul 10, 2013

Yes, absolutely. It seems a lot of people have had similar problems. Since I didn't build the library with Rails in mind (and when I did use Rails with stupidedi, it was ruby 1.8.6 and Rails 2.3.x), I haven't encountered the same problems.

I'd like to continue supporting ruby 1.8.6 through 2.0 if possible, and not introduce a dependency on ActiveSupport. Looking forward to your pull request!

@irobayna
Copy link
Collaborator

irobayna commented May 9, 2014

@seanbehan any updates? are you still seeing problems?

@kputnam
Copy link
Owner

kputnam commented Jun 5, 2014

Closing this issue since some Rails compatibility issues have been fixed, even though others may remain. Patches encouraged, but even documentation of any remaining issues would be helpful.

@kputnam kputnam closed this as completed Jun 5, 2014
@andrewthad
Copy link

On ruby 1.8.7 with rails 2.3.18, I get an error trying to use stupidedi because rails and stupidedi both monkey patch Object with a try method. These are incompatible. Has anyone found a workaround for this? https://github.com/kputnam/stupidedi/blob/master/lib/ruby/try.rb#L17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants