-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Monkey Patching the Ruby Standard Library #23
Comments
Yes, absolutely. It seems a lot of people have had similar problems. Since I didn't build the library with Rails in mind (and when I did use Rails with stupidedi, it was ruby 1.8.6 and Rails 2.3.x), I haven't encountered the same problems. I'd like to continue supporting ruby 1.8.6 through 2.0 if possible, and not introduce a dependency on ActiveSupport. Looking forward to your pull request! |
@seanbehan any updates? are you still seeing problems? |
Closing this issue since some Rails compatibility issues have been fixed, even though others may remain. Patches encouraged, but even documentation of any remaining issues would be helpful. |
On ruby 1.8.7 with rails 2.3.18, I get an error trying to use stupidedi because rails and stupidedi both monkey patch Object with a try method. These are incompatible. Has anyone found a workaround for this? https://github.com/kputnam/stupidedi/blob/master/lib/ruby/try.rb#L17 |
Hi,
Thanks for this library. There is a lot of great work here. I have a suggestion though.
There is a lot of monkey patching to the standard library (https://github.com/kputnam/stupidedi/tree/master/lib/ruby) and it is causing breakage for the Rails app I'm working on.
Are you open to the idea of moving away from monkey patching if I submit a patch?
The text was updated successfully, but these errors were encountered: