Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weights not written for trained model #23

Closed
nspope opened this issue Feb 29, 2020 · 2 comments
Closed

Weights not written for trained model #23

nspope opened this issue Feb 29, 2020 · 2 comments

Comments

@nspope
Copy link

nspope commented Feb 29, 2020

Hi, thanks for developing this intuitive and useful tool.

With python 3.69, tensorflow 1.14.0, keras 2.3.1: weights from the trained model are not saved. This is fixed by changing monitor = 'val_acc' to monitor = 'val_accuracy' at:

https://github.com/kern-lab/diploSHIC/blob/7d55417af438e321c374dadc2f7e58f56107443e/diploSHIC.py#L250

For early stopping to work, the same change needs to made at:

https://github.com/kern-lab/diploSHIC/blob/7d55417af438e321c374dadc2f7e58f56107443e/diploSHIC.py#L243

Perhaps due to a recent change in keras or documentation thereof? (See tensorflow/tensorflow#33163)

Nate

@andrewkern
Copy link
Member

sorry just seeing this issue? is this still affecting things?

@andrewkern
Copy link
Member

closing this issue as it seems stale. feel free to reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants