Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't ignore tube with name 200 chars long #212

Closed
tdg5 opened this issue Nov 6, 2013 · 3 comments
Closed

Can't ignore tube with name 200 chars long #212

tdg5 opened this issue Nov 6, 2013 · 3 comments

Comments

@tdg5
Copy link
Member

tdg5 commented Nov 6, 2013

Though it is possible to watch a tube with a name 200 char long, it is not possible to ignore that tube. Ignoring a tube of len 200 returns BAD_FORMAT.

I haven't been able to figure out why however since ignore seems to use the same pattern for checking the length of the tube name that watch uses. Len 199 does work for me, so probably a comparison type issue somewhere.

Ultimately, since a tube with a name 200 chars long cannot be used (as noted by #211), there's not much reason to watch such a tube until that is fixed.

You should be able to reproduce this issue with the following:

watch xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
ignore xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

For reference, I am using version 1.9+9+g157d88b on Ubuntu 12.04.

@tdg5
Copy link
Member Author

tdg5 commented Nov 8, 2013

stats-tube also seems to be affected:

watch xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
WATCHING 2

stats-tube xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
BAD_FORMAT

@tdg5
Copy link
Member Author

tdg5 commented Nov 9, 2013

pause-tube also appears to be affected, but more severely. Trying to pause a tube with a name longer than 192 causes a BAD_FORMAT error, at least in the version I'm testing against (1.9+9+g157d88b on Ubuntu 12.04)

With 193 x's:

watch xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
WATCHING 2

pause-tube xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx 10
BAD_FORMAT

@kr
Copy link
Member

kr commented Apr 8, 2016

Fixed in 2279f18.

@kr kr closed this as completed Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants