Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird artifact appears in darker backgrounds #74

Closed
Mars7x opened this issue Apr 24, 2023 · 3 comments
Closed

Weird artifact appears in darker backgrounds #74

Mars7x opened this issue Apr 24, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Mars7x
Copy link

Mars7x commented Apr 24, 2023

Describe the bug
If you game uses a darker cover art, then the background will have this weird artifact at the bottom of it.

To Reproduce
Steps to reproduce the behavior:

  1. Set the cover art to anything that has black/dark colours at the bottom of it.

Expected behavior
Be consistent with the rest of the background.

Screenshots
Screenshot from 2023-04-24 08-14-24

Screenshot from 2023-04-24 08-17-06

Screenshot from 2023-04-24 08-17-33

@Mars7x Mars7x added the bug Something isn't working label Apr 24, 2023
@Mars7x Mars7x changed the title Weird artifact appears in darker backgrounds. Weird artifact appears in darker backgrounds Apr 24, 2023
@kra-mo
Copy link
Owner

kra-mo commented Apr 24, 2023

This is not really an artifact. The current way of blurring the game covers for the background is simply downscaling it to 2x3 pixels and then upscaling it to fit the app. This doesn't really work for backgrounds with a lot of color variation so I will need to find a better algorithm.

@kra-mo kra-mo added enhancement New feature or request and removed bug Something isn't working labels Apr 24, 2023
@lorhof1
Copy link

lorhof1 commented May 2, 2023

I tested some things and changing it to 3x4 seems to reduce the issues a bit without impacting other covers.
Before:
Bildschirmfoto vom 2023-05-02 11-15-50
After:
Bildschirmfoto vom 2023-05-02 11-15-17
Cover image used:
Unbenannt

@kra-mo
Copy link
Owner

kra-mo commented May 2, 2023

I will probably just apply a blur later on as this still looks relatively weird. I have already implemented a way of doing it, I just need to optimize it.

@kra-mo kra-mo closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants