Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AUR package is seriously broken #6

Closed
rhysperry111 opened this issue Apr 8, 2022 · 4 comments
Closed

[BUG] AUR package is seriously broken #6

rhysperry111 opened this issue Apr 8, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@rhysperry111
Copy link

rhysperry111 commented Apr 8, 2022

Describe the bug 馃悰
The AUR package (termtyper-git) that you maintain for this project is seriously broken. It does the a pip install into the user's home (a serious problem, as it leaves left over files when uninstalled, and also means it will have to be installed via pip for other users anyway) and fails to list all the needed dependencies (pip).

To Reproduce 馃悾
Steps to reproduce the behavior:

  1. Try and install the package from the AUR
  2. WTF
  3. Audit the PKGBUILD
  4. Die

Expected behavior 馃

  1. Try and install the package from the AUR
  2. :)

Desktop (please complete the following information): 馃

  • OS: Arch Linux

Additional context 馃摑
If you need any help fixing the PKGBUILD, feel free to ask as I maintain a few AUR packages myself.

@rhysperry111 rhysperry111 added the bug Something isn't working label Apr 8, 2022
@kraanzu
Copy link
Owner

kraanzu commented Apr 8, 2022

Yeah about that...It was my first try at building an AUR package and I seriously messed up.

If you need any help fixing the PKGBUILD, feel free to ask as I maintain a few AUR packages myself.

Yes, that would be a great idea ;)

@rhysperry111
Copy link
Author

rhysperry111 commented Apr 8, 2022

Hey dw, it's all good. Once you learn how it's actually super useful - especially when you wanna build some random project but don't wanna mess around removing it afterwards.

Did kinda lose my chill this morning (was busy), so sorry about that.

I'll submit a fixed version of the PKGBUILD to you, and maybe add some comments on why certain things are done if needed :)

(Again.... it's not a huge problem, and it's awesome that you tried too! I was just having a bad morning)

@kraanzu
Copy link
Owner

kraanzu commented Apr 10, 2022

Hey @rhysperry111, just saw that there is an option to add co-maintainers in the AUR.. should I add you there?

@rhysperry111
Copy link
Author

You could add me as a co-maintainer if you want, but here's a patch file for you to do it yourself anyway. You can apply it using git apply. (Had to append .txt to the filename because of github's supported filetypes)

0001-Fix-PKGBUILD.patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants