Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babelHelpers set to inline? #1

Closed
cgatian opened this issue Nov 18, 2021 · 5 comments · Fixed by #2
Closed

babelHelpers set to inline? #1

cgatian opened this issue Nov 18, 2021 · 5 comments · Fixed by #2

Comments

@cgatian
Copy link

cgatian commented Nov 18, 2021

Curious to know why you set babelHelpers inline?

The docs recommend runtime and explicitly say not to use inline.
https://github.com/rollup/plugins/tree/master/packages/babel#babelhelpers

@kraftdorian
Copy link
Owner

Hi, thank you so much for finding that!
I think I just set the default value of that prop explicitly when testing the behavior, and it stayed.

It definitely needs to be changed, I'll give it a try.

@cgatian
Copy link
Author

cgatian commented Nov 18, 2021

So I've been messing around as well, which is how I came across your post.

This Stackblitz could help to rapidly test different setups:
https://stackblitz.com/edit/node-r78guv?file=src/index.js

@cgatian
Copy link
Author

cgatian commented Nov 18, 2021

I think the setup there is actually what you want. Still researching though, there are a lot of properties and sometimes the description is difficult to understand.

@kraftdorian
Copy link
Owner

thank you once again for creating the issue and linking the example, for now, I went with the default config there after looking at https://babeljs.io/docs/en/babel-plugin-transform-runtime.

tested with a few builds and seems like it's working fine.

@kraftdorian kraftdorian pinned this issue Nov 18, 2021
@cgatian
Copy link
Author

cgatian commented Nov 19, 2021

Great. I think the setup you have is correct.

I still am having an issue with the additional babel runtime as a dependency of the package. Maybe a lot library authors are doing it and I never see or noticed it, just something isn't making sense...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants