Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning in VoronoiRegionalizer if not every seed point is inside its region #415

Open
RaczeQ opened this issue Dec 5, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@RaczeQ
Copy link
Collaborator

RaczeQ commented Dec 5, 2023

When seed points are really close to each other, the regions sometimes contain 2 points while others contain 0. The boundary of the regions when mapped from spherical geometry to WGS84 is not 100% fool-proof. The parameter max_meters_between_points steers the precision of this mapping.
The method should show a warning if this situation happens and suggests increasing the precision. Maybe implementing a foolproof solution should be explored (with an optional flag, since it might be slow).

@RaczeQ RaczeQ added the bug Something isn't working label Dec 5, 2023
@RaczeQ
Copy link
Collaborator Author

RaczeQ commented Dec 5, 2023

Example on the map:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant