Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative wildcard address does not match in sub-projects #27

Closed
NiklasRosenstein opened this issue May 16, 2023 · 2 comments
Closed

Relative wildcard address does not match in sub-projects #27

NiklasRosenstein opened this issue May 16, 2023 · 2 comments
Assignees
Labels
type: discussion For topics of discussion.

Comments

@NiklasRosenstein
Copy link
Contributor

NiklasRosenstein commented May 16, 2023

When selecting tasks to run on the command-line, specifying a bare task name matches all tasks with that name in the focus project and all the sub projects. As an example, assuming the following projects and tasks:

: (root project)
  :a (sub project) (focus)
    :a:b (sub project)
      :a:b:task (task) 
    :a:task (task)
  :c (sub project)
    :c:task (task)
  :task (task)

Running krakenw query task with :a as the focus project will select the tasks :a:b:task and :a:task. This is done by transforming the selector from task into .:**:task.

However, krakenw query tas* will only match the task :a:task. I would suggest to also transform this selector from tas* into .:**:tas* automatically as I believe that behavior would be less surprising.

If we do that, the old semantics for matching tas* but only in the current project requires that one explicitly specifies the current project, e.g. .:tas*.

@tetigi
Copy link
Contributor

tetigi commented May 17, 2023

I think this seems reasonable, and FWIW I don't think many people use this feature (at least, I have never seen it used in the wild - typically just the task version that changes to :**:task.

@NiklasRosenstein
Copy link
Contributor Author

NiklasRosenstein commented May 17, 2023

Implemented in 5d3499c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion For topics of discussion.
Projects
None yet
Development

No branches or pull requests

4 participants