Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_lockfile() method to PythonBuildSystems #101

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

alexw9988
Copy link
Contributor

I need a buildsystem-independent way to retrieve the lockfile path, this change therefore adds the get_lockfile() method to all PythonBuildSystem subclasses.

@alexw9988 alexw9988 changed the title Add get_lockfile() method to PythonBuildSystems Draft: Add get_lockfile() method to PythonBuildSystems Aug 10, 2023
@alexw9988
Copy link
Contributor Author

Todo: add changelog entry

@alexw9988 alexw9988 changed the title Draft: Add get_lockfile() method to PythonBuildSystems Add get_lockfile() method to PythonBuildSystems Aug 10, 2023
Copy link

@cdbrkfxrpt cdbrkfxrpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's await Nick's opinion :)

@ntrinquier ntrinquier merged commit 9222f6b into kraken-build:develop Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants