Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add masking. Add auth check #112

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Conversation

alexespencer
Copy link
Contributor

This change:

  • masks password output when running krakenw auth --list by default
  • adds a --no-mask switch to display the plain text password
  • performs a credential check for jfrog.io and github by default, unless --no-check is provided. Most users are tripping up here and having credential check automatically performed (vs requesting it) will help
  • displays curl commands for users to run themselves if they want to, requested via --verbose
  • displays common warnings based upon the response received from JFrog (like using an API token vs an identity token)

Users can edit ~/krakenw/config.toml if they would like a different URL to be used for either jfrog or github:

[auth."helsing.jfrog.io"]
username = "alex.spencer@helsing.ai"
auth_check_url_suffix = "artifactory/api/pypi/python-all/simple/flask/"

For future changes, we'll need to extend the auth abilities, and may want to consider refactoring this so it's easier to maintain

@alexespencer alexespencer marked this pull request as ready for review September 14, 2023 15:24
@NiklasRosenstein NiklasRosenstein merged commit 74b5a4a into develop Sep 18, 2023
13 checks passed
@NiklasRosenstein NiklasRosenstein deleted the asp/auth-list-improvement branch September 18, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants