Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffrs login, install, publish and generate to kraken-std #120

Merged
merged 18 commits into from
Oct 10, 2023

Conversation

alexespencer
Copy link
Contributor

No description provided.

@alexespencer alexespencer self-assigned this Sep 29, 2023
@alexespencer alexespencer marked this pull request as ready for review September 29, 2023 16:22
kraken-std/src/kraken/std/buffrs/manifest.py Outdated Show resolved Hide resolved
kraken-std/src/kraken/std/buffrs/manifest.py Outdated Show resolved Hide resolved
kraken-std/src/kraken/std/buffrs/tasks.py Outdated Show resolved Hide resolved
kraken-std/src/kraken/std/buffrs/tasks.py Outdated Show resolved Hide resolved
kraken-std/.changelog/_unreleased.toml Outdated Show resolved Hide resolved
)


class BuffrsPublishTask(BackgroundTask):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to be a background task now. You just need to move the atomic_file_swap() call into the execute() method and wrap it around the Buffrs command invokation.

@NiklasRosenstein
Copy link
Contributor

🚀

@NiklasRosenstein NiklasRosenstein merged commit d6eb499 into develop Oct 10, 2023
5 of 7 checks passed
@NiklasRosenstein NiklasRosenstein deleted the asp/buffrs-python-codegen branch October 10, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants